Re: [PR] Configurable Lucene analyzer [pinot]

["Jackie-Jiang (via GitHub)" <gi...@apache.org>]

Jackie-Jiang commented on code in PR #12027:
URL: https://github.com/apache/pinot/pull/12027#discussion_r1414737279


##########
pinot-segment-local/src/main/java/org/apache/pinot/segment/local/segment/store/TextIndexUtils.java:
##########
@@ -112,6 +113,12 @@ private static List<String> parseEntryAsString(@Nullable Map<String, String> col
         .map(String::trim).collect(Collectors.toList());
   }
 
+  public static Analyzer getAnalyzerFromFQCN(@Nonnull String luceneAnalyzerFQCN) throws

Review Comment:
   ```suggestion
     public static Analyzer getAnalyzerFromClassName(String luceneAnalyzerClass) throws
   ```



##########
pinot-segment-spi/src/main/java/org/apache/pinot/segment/spi/index/TextIndexConfig.java:
##########
@@ -172,6 +187,11 @@ public AbstractBuilder withLuceneMaxBufferSizeMB(int maxBufferSizeMB) {
       _luceneMaxBufferSizeMB = maxBufferSizeMB;
       return this;
     }
+
+    public AbstractBuilder withLuceneAnalyzerFQCN(String luceneAnalyzerFQCN) {

Review Comment:
   ```suggestion
       public AbstractBuilder withLuceneAnalyzerClass(String luceneAnalyzerClass) {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org