You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zhijiangW <gi...@git.apache.org> on 2017/11/28 06:33:57 UTC

[GitHub] flink issue #4552: [FLINK-7456][network] Implement Netty sender incoming pip...

Github user zhijiangW commented on the issue:

    https://github.com/apache/flink/pull/4552
  
    @NicoK , thanks for focusing on the last PR.
    
    I am supposed to divide this into two separate ones as you said. But I am afraid some current tests may fail if I only modify and enable the credit-based process on sender side, otherwise I may need to create a temporary handler in parallel with `PartitionRequestQueue`.
    
    As you said, the latter mainly replaces the `PartitionRequestClientHandler` with the contents of `CreditBasedClientHandler`, also it replaces the `CreditBasedClientHandler` class name in previous added tests and remove previous temporary codes in `ResultPartitionType` to make fixed buffer pool work.
    
    If it still brings difficulty for your review, then I will try to divide it then. : )


---