You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/07/08 23:24:31 UTC

[GitHub] [incubator-superset] graceguo-supercat opened a new pull request #10261: Revert "feat: minor reorder SQL Lab Tab controls"

graceguo-supercat opened a new pull request #10261:
URL: https://github.com/apache/incubator-superset/pull/10261


   Reverts apache/incubator-superset#10257
   
   sorry merged by mistake!!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat closed pull request #10261: fix: Revert "feat: minor reorder SQL Lab Tab controls"

Posted by GitBox <gi...@apache.org>.
graceguo-supercat closed pull request #10261:
URL: https://github.com/apache/incubator-superset/pull/10261


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] mistercrunch commented on pull request #10261: fix: Revert "feat: minor reorder SQL Lab Tab controls"

Posted by GitBox <gi...@apache.org>.
mistercrunch commented on pull request #10261:
URL: https://github.com/apache/incubator-superset/pull/10261#issuecomment-655808518


   As far as I'm concerned, feel free to push forward if that's easier. Unless someone feels strongly about doing the revert (?)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org

[GitHub] [incubator-superset] graceguo-supercat commented on pull request #10261: fix: Revert "feat: minor reorder SQL Lab Tab controls"

Posted by GitBox <gi...@apache.org>.
graceguo-supercat commented on pull request #10261:
URL: https://github.com/apache/incubator-superset/pull/10261#issuecomment-655809770


   Ok I will abandon this PR and let's discuss how to improve it in #10257 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org