You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2020/10/25 06:11:54 UTC
[GitHub] [dubbo-go] fangyincheng opened a new pull request #802: fixed url encode
fangyincheng opened a new pull request #802:
URL: https://github.com/apache/dubbo-go/pull/802
**What this PR does**:
fix that “,” code twice become “%252”.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] codecov-io commented on pull request #802: fixed url encode
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #802:
URL: https://github.com/apache/dubbo-go/pull/802#issuecomment-716100747
# [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/802?src=pr&el=h1) Report
> Merging [#802](https://codecov.io/gh/apache/dubbo-go/pull/802?src=pr&el=desc) into [develop](https://codecov.io/gh/apache/dubbo-go/commit/45a36569a8ed7d2fb9321d3ea6443702d7c380b4?el=desc) will **decrease** coverage by `0.03%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/dubbo-go/pull/802?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #802 +/- ##
===========================================
- Coverage 59.80% 59.76% -0.04%
===========================================
Files 259 259
Lines 12752 12752
===========================================
- Hits 7626 7621 -5
Misses 4171 4171
- Partials 955 960 +5
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo-go/pull/802?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [config\_center/nacos/facade.go](https://codecov.io/gh/apache/dubbo-go/pull/802/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9mYWNhZGUuZ28=) | `79.31% <0.00%> (-10.35%)` | :arrow_down: |
| [metadata/report/delegate/delegate\_report.go](https://codecov.io/gh/apache/dubbo-go/pull/802/diff?src=pr&el=tree#diff-bWV0YWRhdGEvcmVwb3J0L2RlbGVnYXRlL2RlbGVnYXRlX3JlcG9ydC5nbw==) | `29.66% <0.00%> (-9.33%)` | :arrow_down: |
| [remoting/kubernetes/watch.go](https://codecov.io/gh/apache/dubbo-go/pull/802/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy93YXRjaC5nbw==) | `75.00% <0.00%> (-4.35%)` | :arrow_down: |
| [remoting/kubernetes/client.go](https://codecov.io/gh/apache/dubbo-go/pull/802/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9jbGllbnQuZ28=) | `72.72% <0.00%> (-3.04%)` | :arrow_down: |
| [config\_center/nacos/client.go](https://codecov.io/gh/apache/dubbo-go/pull/802/diff?src=pr&el=tree#diff-Y29uZmlnX2NlbnRlci9uYWNvcy9jbGllbnQuZ28=) | `65.26% <0.00%> (-2.11%)` | :arrow_down: |
| [remoting/kubernetes/registry\_controller.go](https://codecov.io/gh/apache/dubbo-go/pull/802/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9yZWdpc3RyeV9jb250cm9sbGVyLmdv) | `50.20% <0.00%> (-1.23%)` | :arrow_down: |
| [remoting/kubernetes/listener.go](https://codecov.io/gh/apache/dubbo-go/pull/802/diff?src=pr&el=tree#diff-cmVtb3Rpbmcva3ViZXJuZXRlcy9saXN0ZW5lci5nbw==) | `50.52% <0.00%> (ø)` | |
| [filter/filter\_impl/hystrix\_filter.go](https://codecov.io/gh/apache/dubbo-go/pull/802/diff?src=pr&el=tree#diff-ZmlsdGVyL2ZpbHRlcl9pbXBsL2h5c3RyaXhfZmlsdGVyLmdv) | `70.19% <0.00%> (+2.88%)` | :arrow_up: |
| [registry/consul/service\_discovery.go](https://codecov.io/gh/apache/dubbo-go/pull/802/diff?src=pr&el=tree#diff-cmVnaXN0cnkvY29uc3VsL3NlcnZpY2VfZGlzY292ZXJ5Lmdv) | `73.64% <0.00%> (+6.58%)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo-go/pull/802?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo-go/pull/802?src=pr&el=footer). Last update [45a3656...5a089ff](https://codecov.io/gh/apache/dubbo-go/pull/802?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks merged pull request #802: Fix:fixed url encode
Posted by GitBox <gi...@apache.org>.
AlexStocks merged pull request #802:
URL: https://github.com/apache/dubbo-go/pull/802
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] zouyx commented on pull request #802: Fix:fixed url encode
Posted by GitBox <gi...@apache.org>.
zouyx commented on pull request #802:
URL: https://github.com/apache/dubbo-go/pull/802#issuecomment-716281378
> Pls do not merge until @fangyincheng adds an ut.
Agree
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org
[GitHub] [dubbo-go] AlexStocks commented on pull request #802: fixed url encode
Posted by GitBox <gi...@apache.org>.
AlexStocks commented on pull request #802:
URL: https://github.com/apache/dubbo-go/pull/802#issuecomment-716280507
Pls do not merge until @fangyincheng adds an ut.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org