You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2017/09/19 09:03:47 UTC

[GitHub] spark pull request #18805: [SPARK-19112][CORE] Support for ZStandard codec

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18805#discussion_r139635152
  
    --- Diff: LICENSE ---
    @@ -269,6 +269,7 @@ The text of each license is also included at licenses/LICENSE-[project].txt.
          (BSD 3 Clause) d3.min.js (https://github.com/mbostock/d3/blob/master/LICENSE)
          (BSD 3 Clause) DPark (https://github.com/douban/dpark/blob/master/LICENSE)
          (BSD 3 Clause) CloudPickle (https://github.com/cloudpipe/cloudpickle/blob/master/LICENSE)
    +     (BSD 2 Clause) Zstd-jni (https://github.com/luben/zstd-jni/blob/master/LICENSE)
    --- End diff --
    
    ZStandard itself is also included, not just zstd-jni. We'd need an entry for it, and its LICENSE as below.
    https://github.com/luben/zstd-jni/tree/master/src/main/native


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org