[GitHub] [arrow-datafusion] Jefffrey commented on pull request #5785: Planner: normalize_ident only when enable_ident_normalization is enabled

["Jefffrey (via GitHub)" <gi...@apache.org>]

Jefffrey commented on PR #5785:
URL: https://github.com/apache/arrow-datafusion/pull/5785#issuecomment-1491812127

   > While working on this PR, I also noticed that there are places not related to the planner which also normalize names such as column. I wonder if it's valuable to also make these method configurable to enable ident normalization?
   > 
   > https://github.com/apache/arrow-datafusion/blob/c09edade14d456f1d2161c5ebb8c1e51e592a8ef/datafusion/common/src/column.rs#L73
   
   I had some thoughts about this previously (not this specific function, but still applicable): https://github.com/apache/arrow-datafusion/pull/5183#discussion_r1096603578
   
   Generally I'm not sure how exactly to be able to toggle normalization at that level (the common crate) without API changes to dependent functions, like `from_qualified_name(...)` in `Column` as you've highlighted


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org