You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2022/07/19 17:40:09 UTC

[GitHub] [phoenix] gjacoby126 commented on a diff in pull request #1462: PHOENIX-6746 Test suite executions do not provide usable logs

gjacoby126 commented on code in PR #1462:
URL: https://github.com/apache/phoenix/pull/1462#discussion_r924792938


##########
phoenix-core/pom.xml:
##########
@@ -568,6 +568,26 @@
     </dependency>
 
     <!-- Other test dependencies -->
+    <dependency>
+        <groupId>org.apache.logging.log4j</groupId>
+        <artifactId>log4j-api</artifactId>
+        <scope>test</scope>
+    </dependency>
+    <dependency>
+        <groupId>org.apache.logging.log4j</groupId>
+        <artifactId>log4j-core</artifactId>

Review Comment:
   By including log4j-core as a test dependency, do we create a problem if someone tries to use phoenix-core as a library in an application that wants to use logback / another slf4j implementation and then writes a test using Phoenix?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org