You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/11/26 07:00:00 UTC

[GitHub] [incubator-superset] mkdym opened a new issue #11822: Shouldn't print datasouce user&&password when datasource crash

mkdym opened a new issue #11822:
URL: https://github.com/apache/incubator-superset/issues/11822


   Superset prints clickhouse datasource user&&password within connection string when datasource crash.
   
   ### Expected results
   
   Do not print user&&password.
   
   ### Actual results
   
   Print user&&password.
   
   #### Screenshots
   
   ![image](https://user-images.githubusercontent.com/10892624/100317090-b4665e00-2ff6-11eb-9177-852df9b70258.png)
   
   #### How to reproduce the bug
   
   1. Add clickhouse datasource
   2. Make chart with clickhouse datasource table.
   3. Shutdown clickhouse server.
   4. Open above chart.
   
   ### Environment
   
   - superset version: `0.37.2`
   - python version: `python --version`
   - docker image repo: `https://github.com/amancevice/docker-superset`
   - docker image version: `amancevice/superset:0.37.2`
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] dpgaspar commented on issue #11822: Shouldn't print datasouce user&&password when datasource crash

Posted by GitBox <gi...@apache.org>.
dpgaspar commented on issue #11822:
URL: https://github.com/apache/incubator-superset/issues/11822#issuecomment-734407717


   Thank you for reporting, can you provide the server logs?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org


[GitHub] [incubator-superset] mkdym commented on issue #11822: Shouldn't print datasouce user&&password when datasource crash

Posted by GitBox <gi...@apache.org>.
mkdym commented on issue #11822:
URL: https://github.com/apache/incubator-superset/issues/11822#issuecomment-734535972


   ![image](https://user-images.githubusercontent.com/10892624/100401206-c2b68780-3093-11eb-97f0-d47a1b43dcf4.png)
   
   Reproduced by these steps:
   1. deploy clickhouse-server(yandex/clickhouse-server:20.3) and superset(amancevice/superset:0.37.2)
   2. add clickhouse databases to superset
   3. open sqllab, select clickhouse table, do query 'SELECT now()'
   4. docker stop clickhouse-server
   5. click 'run query' again
   
   I fixed the issue temporarily by filter reponse json message:
   ![image](https://user-images.githubusercontent.com/10892624/100402398-1aa2bd80-3097-11eb-8629-35f9c9cd9d37.png)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org