You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hudi.apache.org by leesf <le...@gmail.com> on 2020/01/03 05:55:31 UTC
[Workflow] Redo log statements using SLF4J
Hi all,
Since we are going to redo log statements in hudi[1]. And big thanks to all
for their work to provide PRs actively[2].
However we do need fully verify that the log4j would work well in
spark/hive/presto etc before merging into master branch, mainly considering
the packages conflict. So instead of merging PRs directly into the master
branch, a better solution would be merging these PRs into newly created
redo-log branch. After finishing all redo work and fully tested and
verified(I will help to verify and any others helpers are highly welcome),
then we could merge it into master branch. Any thoughts?
Best,
Leesf
[1] https://issues.apache.org/jira/browse/HUDI-233
[2] https://github.com/apache/incubator-hudi/pull/1168
https://github.com/apache/incubator-hudi/pull/1163
https://github.com/apache/incubator-hudi/pull/1161
https://github.com/apache/incubator-hudi/pull/1152
Re: [Workflow] Redo log statements using SLF4J
Posted by leesf <le...@gmail.com>.
Thanks @vino, @pratyaksh and @vinoth, will redo log statement In this way.
Best,
Leesf
Vinoth Chandar <vi...@apache.org> 于2020年1月3日周五 下午11:57写道：
> +1 as well ..
>
> On Fri, Jan 3, 2020 at 12:09 AM Pratyaksh Sharma <pr...@gmail.com>
> wrote:
>
> > Hi,
> >
> > I will volunteer for the testing and verification part.
> >
> > On Fri, Jan 3, 2020 at 1:27 PM vino yang <ya...@gmail.com> wrote:
> >
> > > Hi Leesf,
> > >
> > > Thanks for this proposal. It makes sense to me.
> > > If I have time, I will help to verify this work.
> > >
> > > so, +1 from my side.
> > >
> > > Best,
> > > Vino
> > >
> > > leesf <le...@gmail.com> 于2020年1月3日周五 下午1:55写道：
> > >
> > > > Hi all,
> > > >
> > > > Since we are going to redo log statements in hudi[1]. And big thanks
> to
> > > all
> > > > for their work to provide PRs actively[2].
> > > >
> > > > However we do need fully verify that the log4j would work well in
> > > > spark/hive/presto etc before merging into master branch, mainly
> > > considering
> > > > the packages conflict. So instead of merging PRs directly into the
> > master
> > > > branch, a better solution would be merging these PRs into newly
> created
> > > > redo-log branch. After finishing all redo work and fully tested and
> > > > verified(I will help to verify and any others helpers are highly
> > > welcome),
> > > > then we could merge it into master branch. Any thoughts?
> > > >
> > > > Best,
> > > > Leesf
> > > >
> > > > [1] https://issues.apache.org/jira/browse/HUDI-233
> > > > [2] https://github.com/apache/incubator-hudi/pull/1168
> > > > https://github.com/apache/incubator-hudi/pull/1163
> > > > https://github.com/apache/incubator-hudi/pull/1161
> > > > https://github.com/apache/incubator-hudi/pull/1152
> > > >
> > >
> >
>
Re: [Workflow] Redo log statements using SLF4J
Posted by Vinoth Chandar <vi...@apache.org>.
+1 as well ..
On Fri, Jan 3, 2020 at 12:09 AM Pratyaksh Sharma <pr...@gmail.com>
wrote:
> Hi,
>
> I will volunteer for the testing and verification part.
>
> On Fri, Jan 3, 2020 at 1:27 PM vino yang <ya...@gmail.com> wrote:
>
> > Hi Leesf,
> >
> > Thanks for this proposal. It makes sense to me.
> > If I have time, I will help to verify this work.
> >
> > so, +1 from my side.
> >
> > Best,
> > Vino
> >
> > leesf <le...@gmail.com> 于2020年1月3日周五 下午1:55写道：
> >
> > > Hi all,
> > >
> > > Since we are going to redo log statements in hudi[1]. And big thanks to
> > all
> > > for their work to provide PRs actively[2].
> > >
> > > However we do need fully verify that the log4j would work well in
> > > spark/hive/presto etc before merging into master branch, mainly
> > considering
> > > the packages conflict. So instead of merging PRs directly into the
> master
> > > branch, a better solution would be merging these PRs into newly created
> > > redo-log branch. After finishing all redo work and fully tested and
> > > verified(I will help to verify and any others helpers are highly
> > welcome),
> > > then we could merge it into master branch. Any thoughts?
> > >
> > > Best,
> > > Leesf
> > >
> > > [1] https://issues.apache.org/jira/browse/HUDI-233
> > > [2] https://github.com/apache/incubator-hudi/pull/1168
> > > https://github.com/apache/incubator-hudi/pull/1163
> > > https://github.com/apache/incubator-hudi/pull/1161
> > > https://github.com/apache/incubator-hudi/pull/1152
> > >
> >
>
Re: [Workflow] Redo log statements using SLF4J
Posted by Pratyaksh Sharma <pr...@gmail.com>.
Hi,
I will volunteer for the testing and verification part.
On Fri, Jan 3, 2020 at 1:27 PM vino yang <ya...@gmail.com> wrote:
> Hi Leesf,
>
> Thanks for this proposal. It makes sense to me.
> If I have time, I will help to verify this work.
>
> so, +1 from my side.
>
> Best,
> Vino
>
> leesf <le...@gmail.com> 于2020年1月3日周五 下午1:55写道：
>
> > Hi all,
> >
> > Since we are going to redo log statements in hudi[1]. And big thanks to
> all
> > for their work to provide PRs actively[2].
> >
> > However we do need fully verify that the log4j would work well in
> > spark/hive/presto etc before merging into master branch, mainly
> considering
> > the packages conflict. So instead of merging PRs directly into the master
> > branch, a better solution would be merging these PRs into newly created
> > redo-log branch. After finishing all redo work and fully tested and
> > verified(I will help to verify and any others helpers are highly
> welcome),
> > then we could merge it into master branch. Any thoughts?
> >
> > Best,
> > Leesf
> >
> > [1] https://issues.apache.org/jira/browse/HUDI-233
> > [2] https://github.com/apache/incubator-hudi/pull/1168
> > https://github.com/apache/incubator-hudi/pull/1163
> > https://github.com/apache/incubator-hudi/pull/1161
> > https://github.com/apache/incubator-hudi/pull/1152
> >
>
Re: [Workflow] Redo log statements using SLF4J
Posted by vino yang <ya...@gmail.com>.
Hi Leesf,
Thanks for this proposal. It makes sense to me.
If I have time, I will help to verify this work.
so, +1 from my side.
Best,
Vino
leesf <le...@gmail.com> 于2020年1月3日周五 下午1:55写道：
> Hi all,
>
> Since we are going to redo log statements in hudi[1]. And big thanks to all
> for their work to provide PRs actively[2].
>
> However we do need fully verify that the log4j would work well in
> spark/hive/presto etc before merging into master branch, mainly considering
> the packages conflict. So instead of merging PRs directly into the master
> branch, a better solution would be merging these PRs into newly created
> redo-log branch. After finishing all redo work and fully tested and
> verified(I will help to verify and any others helpers are highly welcome),
> then we could merge it into master branch. Any thoughts?
>
> Best,
> Leesf
>
> [1] https://issues.apache.org/jira/browse/HUDI-233
> [2] https://github.com/apache/incubator-hudi/pull/1168
> https://github.com/apache/incubator-hudi/pull/1163
> https://github.com/apache/incubator-hudi/pull/1161
> https://github.com/apache/incubator-hudi/pull/1152
>