You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "Blake Bender (Jira)" <ji...@apache.org> on 2020/11/04 20:21:00 UTC
[jira] [Closed] (GEODE-8674) CLI DataInput object leaks internal
buffer when allocating ctor is called
[ https://issues.apache.org/jira/browse/GEODE-8674?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Blake Bender closed GEODE-8674.
-------------------------------
> CLI DataInput object leaks internal buffer when allocating ctor is called
> -------------------------------------------------------------------------
>
> Key: GEODE-8674
> URL: https://issues.apache.org/jira/browse/GEODE-8674
> Project: Geode
> Issue Type: Improvement
> Components: native client
> Reporter: Blake Bender
> Assignee: Blake Bender
> Priority: Major
> Fix For: 1.14.0
>
>
> The CLI DataInput object has two ctors, one of which copies the passed-in buffer parameter via new[] and one of which doesn't. In the event that the former is called, the buffer is leaked when the object is deleted/Disposed. Here's the current code for CLI `DataInput::~DataInput`:
> ```
> ~DataInput( ) \{ Cleanup(); }
> ```
> And the code for `DataInput::Cleanup`:
> ```
> void DataInput::Cleanup()
> {
> //TODO:
> //GF_SAFE_DELETE_ARRAY(m_buffer);
> }
> ```
> So apparently this bug has been known for some time (?!?), but has never been fixed.
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)