[jira] [Commented] (CASSANDRA-8805) runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted

["Benedict (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANDRA-8805?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14555778#comment-14555778 ] 

Benedict commented on CASSANDRA-8805:
-------------------------------------

[~carlyeks]: The general approach looks good, but could I get a proper (rebased) branch up? If you could get things into a "ready to commit" state with CHANGES.txt wired up as well, that would be appreciated.

I would like to move away from dealing with patch files, as it isn't conducive to the new commit process.

 

> runWithCompactionsDisabled only cancels compactions, which is not the only source of markCompacted
> --------------------------------------------------------------------------------------------------
>
>                 Key: CASSANDRA-8805
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-8805
>             Project: Cassandra
>          Issue Type: Bug
>          Components: Core
>            Reporter: Benedict
>            Assignee: Carl Yeksigian
>             Fix For: 2.1.x
>
>         Attachments: 8805-2.1.txt
>
>
> Operations like repair that may operate over all sstables cancel compactions before beginning, and fail if there are any files marked compacting after doing so. Redistribution of index summaries is not a compaction, so is not cancelled by this action, but does mark sstables as compacting, so such an action will fail to initiate if there is an index summary redistribution in progress. It seems that IndexSummaryManager needs to register itself as interruptible along with compactions (AFAICT no other actions that may markCompacting are not themselves compactions).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)