You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by mtaylor <gi...@git.apache.org> on 2016/09/16 14:40:08 UTC
[GitHub] activemq-artemis pull request #779: Add Unique ClientID on Server
GitHub user mtaylor opened a pull request:
https://github.com/apache/activemq-artemis/pull/779
Add Unique ClientID on Server
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtaylor/activemq-artemis ServerClientIds
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/779.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #779
----
commit d7c6d343c19229254e5dc4f8d9bd5a77b6820920
Author: Martyn Taylor <mt...@redhat.com>
Date: 2016-09-15T13:15:54Z
Add Unique ClientID on Server
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #779: Add Unique ClientID on Server
Posted by mtaylor <gi...@git.apache.org>.
Github user mtaylor commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/779#discussion_r79185878
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
@@ -2396,6 +2400,26 @@ public long getUptimeMillis() {
return new Date().getTime() - startDate.getTime();
}
+ public boolean addClientConnection(String clientId, boolean unique) {
+ final AtomicInteger i = connectedClientIds.putIfAbsent(clientId, new AtomicInteger(1));
+ if (i != null) {
+ if (unique && i.get() != 0) {
+ return false;
+ }
+ else {
+ i.incrementAndGet();
+ connectedClientIds.put(clientId, i);
--- End diff --
This is to avoid race condition with remove.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #779: Add Unique ClientID on Server
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/779
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request #779: Add Unique ClientID on Server
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:
https://github.com/apache/activemq-artemis/pull/779#discussion_r79185211
--- Diff: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ActiveMQServerImpl.java ---
@@ -2396,6 +2400,26 @@ public long getUptimeMillis() {
return new Date().getTime() - startDate.getTime();
}
+ public boolean addClientConnection(String clientId, boolean unique) {
+ final AtomicInteger i = connectedClientIds.putIfAbsent(clientId, new AtomicInteger(1));
+ if (i != null) {
+ if (unique && i.get() != 0) {
--- End diff --
i.get() will always be 1. I guess just unique would be enough on this if?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---