You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@flink.apache.org by GitBox <gi...@apache.org> on 2022/03/23 07:34:59 UTC

[GitHub] [flink-kubernetes-operator] wangyang0918 opened a new pull request #99: [FLINK-26816] Verify the java doc is consistent with the code implementation

wangyang0918 opened a new pull request #99:
URL: https://github.com/apache/flink-kubernetes-operator/pull/99


   We need to verity the java doc is consistent with the code implementation via the CI. Otherwise, it is very easy to forget to re-generate the java doc after some changes. Thanks `git diff` we could make the verification easier :)
   
   A failed case could be found here. https://github.com/wangyang0918/flink-kubernetes-operator/runs/5656298427?check_suite_focus=true
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #99: [FLINK-26816] Verify the java doc is consistent with the code implementation

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #99:
URL: https://github.com/apache/flink-kubernetes-operator/pull/99#issuecomment-1076024101


   cc @gyfora 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] morhidi commented on pull request #99: [FLINK-26816] Verify the java doc is consistent with the code implementation

Posted by GitBox <gi...@apache.org>.
morhidi commented on pull request #99:
URL: https://github.com/apache/flink-kubernetes-operator/pull/99#issuecomment-1076024279


   +1 nice


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] wangyang0918 commented on pull request #99: [FLINK-26816] Verify the java doc is consistent with the code implementation

Posted by GitBox <gi...@apache.org>.
wangyang0918 commented on pull request #99:
URL: https://github.com/apache/flink-kubernetes-operator/pull/99#issuecomment-1076041582


   Thanks @morhidi for your review. Merging now.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [flink-kubernetes-operator] wangyang0918 merged pull request #99: [FLINK-26816] Verify the java doc is consistent with the code implementation

Posted by GitBox <gi...@apache.org>.
wangyang0918 merged pull request #99:
URL: https://github.com/apache/flink-kubernetes-operator/pull/99


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org