[GitHub] [incubator-doris] Lchangliang commented on a diff in pull request #8923: [Feature] Support compression prop

[GitBox <gi...@apache.org>]

Lchangliang commented on code in PR #8923:
URL: https://github.com/apache/incubator-doris/pull/8923#discussion_r851190905


##########
be/src/olap/tablet_schema.h:
##########
@@ -169,6 +172,7 @@ class TabletSchema {
     size_t _num_short_key_columns = 0;
     size_t _num_rows_per_row_block = 0;
     CompressKind _compress_kind = COMPRESS_NONE;
+    segment_v2::CompressionTypePB _compression_type = segment_v2::CompressionTypePB::NO_COMPRESSION;

Review Comment:
   I think it is just a zero value. It will be set after creation like _compress_kind. 
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org