[jira] [Commented] (CASSANALYTICS-66) Replace org.jetbrains.annotations.NotNull

["Yifan Cai (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CASSANALYTICS-66?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17985114#comment-17985114 ] 

Yifan Cai commented on CASSANALYTICS-66:
----------------------------------------

No objections. It is good to flag this early on. 

> Replace org.jetbrains.annotations.NotNull 
> ------------------------------------------
>
>                 Key: CASSANALYTICS-66
>                 URL: https://issues.apache.org/jira/browse/CASSANALYTICS-66
>             Project: Apache Cassandra Analytics
>          Issue Type: Task
>            Reporter: Stefan Miklosovic
>            Priority: Normal
>
> Is there some important reason why these annotations are used? When I copy some class with them to new project, they are not found. Is this because the project is developed in IntelliJ IDEA most often and there is some support for that in IDE itself when something might be null and so on?
> I do not think we should be biased towards one IDE in the code. 
> Based on this (1) all of these annotations are recognized by IDEA. I think we should use something like javax.annotations.(Nullable|Nonnull) to be the most neutral possible. 
> (1) https://www.jetbrains.com/help/idea/annotating-source-code.html#default_nullability_annotations



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org