You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/09/18 12:48:32 UTC

[GitHub] [incubator-kvrocks] PragmaTwice commented on pull request #885: feat: added disableWAL option

PragmaTwice commented on PR #885:
URL: https://github.com/apache/incubator-kvrocks/pull/885#issuecomment-1250263776

   > So, I've reworked PR with `WriteWithDefault`. What about `Delete`? There was write_options and I removed it.
   
   I think you can recover the WriteOptions parameter, and just expose a method `WriteOptions Storage::DefaultWriteOptions()`.
   
   And you can also add something like `DeleteWithDefault(...) { Delete(DefaultWriteOptions(), ...) }` if you like.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org