You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/21 07:06:30 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #34337: [SPARK-37066][SQL] Improve error message to show file path when failed to read next file
cloud-fan commented on a change in pull request #34337:
URL: https://github.com/apache/spark/pull/34337#discussion_r733377326
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/FileScanRDD.scala
##########
@@ -177,6 +177,10 @@ class FileScanRDD(
throw QueryExecutionErrors.cannotReadParquetFilesError(e)
}
throw e
+ case e: Exception =>
+ logError(s"Throw ${e.getClass.getSimpleName}: ${e.getMessage} " +
Review comment:
do we need the log? there is no log in other `catch` clauses around here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org