You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "amoghrajesh (via GitHub)" <gi...@apache.org> on 2026/01/30 10:50:58 UTC
[PR] Exploring possibility of moving DagAttributeTypes to execution API spec [airflow]
amoghrajesh opened a new pull request, #61251:
URL: https://github.com/apache/airflow/pull/61251
<!--
Thank you for contributing!
Please provide above a brief description of the changes made in this pull request.
Write a good git commit message following this guide: http://chris.beams.io/posts/git-commit/
Please make sure that your code changes are covered with tests.
And in case of new features or big changes remember to adjust the documentation.
Feel free to ping (in general) for the review if you do not see reaction for a few days
(72 Hours is the minimum reaction time you can expect from volunteers) - we sometimes miss notifications.
In case of an existing issue, reference it using one of the following:
* closes: #ISSUE
* related: #ISSUE
-->
---
##### Was generative AI tooling used to co-author this PR?
<!--
If generative AI tooling has been used in the process of authoring this PR, please
change below checkbox to `[X]` followed by the name of the tool, uncomment the "Generated-by".
-->
- [x] No
<!--
Generated-by: [Tool Name] following [the guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#gen-ai-assisted-contributions)
-->
Ok hear me out, this might be odd, but since its just one enum it didn't feel too wrong.
Instead of creating a shared library or duplicating the enum, we expose `DagAttributeTypes` through the Execution API's OpenAPI schema. This allows the Task SDK to get the enum values via code generation, keeping SDK and core serialization protocol in sync automatically.
Why this approach:
- SDK only needs 2 values (OP, TASK_GROUP) from the 30+ value `DagAttributeTypes` enum
- Adding a shared library felt heavyweight for just 2 string constants
- Hardcoding risked typos whcih could lead to broken contract
- OpenAPI schema generation provides automatic sync mechanism
The `DagAttributeTypes` enum is added to get_extra_schemas() and exposed in the API spec. When task-sdk regenerates its models, it gets a properly typed enum that matches what core expects for `serialize_for_task_group()`
Trade-off: This enum isn't actually used in API requests/responses - it's purely for the serialization. However, since we already generate SDK models from the API spec and need these exact values there, reusing the generation mechanism felt pragmatic.
I considered the alternative of creating `shared/serialization` library but it deemed overkill for 2 values used in few places.
---
* Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/contributing-docs/05_pull_requests.rst#pull-request-guidelines)** for more information. Note: commit author/co-author name and email in commits become permanently public when merged.
* For fundamental code changes, an Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvement+Proposals)) is needed.
* When adding dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
* For significant user-facing changes create newsfragment: `{pr_number}.significant.rst` or `{issue_number}.significant.rst`, in [airflow-core/newsfragments](https://github.com/apache/airflow/tree/main/airflow-core/newsfragments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exploring possibility of moving DagAttributeTypes to execution API spec [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #61251:
URL: https://github.com/apache/airflow/pull/61251#discussion_r2752368729
##########
airflow-core/src/airflow/api_fastapi/execution_api/app.py:
##########
@@ -278,6 +279,11 @@ def get_extra_schemas() -> dict[str, dict]:
"TaskInstanceState": {"type": "string", "enum": list(TaskInstanceState)},
"WeightRule": {"type": "string", "enum": list(WeightRule)},
"TriggerRule": {"type": "string", "enum": list(TriggerRule)},
+ "DagAttributeTypes": {
+ "type": "string",
+ "enum": [DagAttributeTypes.OP.value, DagAttributeTypes.TASK_GROUP.value],
+ "x-enum-varnames": [DagAttributeTypes.OP.name, DagAttributeTypes.TASK_GROUP.name],
Review Comment:
Can these be dynamic? e.g. `[m.name for m in DagAttributeTypes.__members__]`
##########
airflow-core/src/airflow/api_fastapi/execution_api/app.py:
##########
@@ -278,6 +279,11 @@ def get_extra_schemas() -> dict[str, dict]:
"TaskInstanceState": {"type": "string", "enum": list(TaskInstanceState)},
"WeightRule": {"type": "string", "enum": list(WeightRule)},
"TriggerRule": {"type": "string", "enum": list(TriggerRule)},
+ "DagAttributeTypes": {
+ "type": "string",
+ "enum": [DagAttributeTypes.OP.value, DagAttributeTypes.TASK_GROUP.value],
+ "x-enum-varnames": [DagAttributeTypes.OP.name, DagAttributeTypes.TASK_GROUP.name],
Review Comment:
Can these be dynamic? e.g. `[m.name for m in DagAttributeTypes]`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exploring possibility of moving DagAttributeTypes to execution API spec [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh merged PR #61251:
URL: https://github.com/apache/airflow/pull/61251
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exploring possibility of moving DagAttributeTypes to execution API spec [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on PR #61251:
URL: https://github.com/apache/airflow/pull/61251#issuecomment-3842150560
@uranusjr could i request a re review on this one?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exploring possibility of moving DagAttributeTypes to execution API spec [airflow]
Posted by "uranusjr (via GitHub)" <gi...@apache.org>.
uranusjr commented on code in PR #61251:
URL: https://github.com/apache/airflow/pull/61251#discussion_r2752368729
##########
airflow-core/src/airflow/api_fastapi/execution_api/app.py:
##########
@@ -278,6 +279,11 @@ def get_extra_schemas() -> dict[str, dict]:
"TaskInstanceState": {"type": "string", "enum": list(TaskInstanceState)},
"WeightRule": {"type": "string", "enum": list(WeightRule)},
"TriggerRule": {"type": "string", "enum": list(TriggerRule)},
+ "DagAttributeTypes": {
+ "type": "string",
+ "enum": [DagAttributeTypes.OP.value, DagAttributeTypes.TASK_GROUP.value],
+ "x-enum-varnames": [DagAttributeTypes.OP.name, DagAttributeTypes.TASK_GROUP.name],
Review Comment:
Can these be dynamic? e.g. `[m.name for m in DagAttributeTypes]` so the overhead of having all the attribute types wouldn’t be that much (just a couple hundred extra bytes in the generated type)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Exploring possibility of moving DagAttributeTypes to execution API spec [airflow]
Posted by "amoghrajesh (via GitHub)" <gi...@apache.org>.
amoghrajesh commented on code in PR #61251:
URL: https://github.com/apache/airflow/pull/61251#discussion_r2752378343
##########
airflow-core/src/airflow/api_fastapi/execution_api/app.py:
##########
@@ -278,6 +279,11 @@ def get_extra_schemas() -> dict[str, dict]:
"TaskInstanceState": {"type": "string", "enum": list(TaskInstanceState)},
"WeightRule": {"type": "string", "enum": list(WeightRule)},
"TriggerRule": {"type": "string", "enum": list(TriggerRule)},
+ "DagAttributeTypes": {
+ "type": "string",
+ "enum": [DagAttributeTypes.OP.value, DagAttributeTypes.TASK_GROUP.value],
+ "x-enum-varnames": [DagAttributeTypes.OP.name, DagAttributeTypes.TASK_GROUP.name],
Review Comment:
The reason i didnt do it was because I wanted only 2 keys in the shared spec. The original enum is 30+ keys
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org