[GitHub] [incubator-kyuubi] yaooqinn commented on a change in pull request #2170: [KYUUBI #2019] Hive Backend Engine - GetTableTypes Operation

[GitBox <gi...@apache.org>]

yaooqinn commented on a change in pull request #2170:
URL: https://github.com/apache/incubator-kyuubi/pull/2170#discussion_r829999219



##########
File path: externals/kyuubi-hive-sql-engine/src/test/scala/org/apache/kyuubi/engine/hive/operation/HiveOperationSuite.scala
##########
@@ -149,6 +149,20 @@ class HiveOperationSuite extends HiveJDBCTestHelper {
     }
   }
 
+  test("get table types") {
+    withJdbcStatement() { statement =>
+      val resultSet = statement.getConnection.getMetaData.getTableTypes
+      val expected = Set("TABLE", "VIEW", "INDEX_TABLE", "MATERIALIZED_VIEW")

Review comment:
       hive has 2 output type
   - hive: "TABLE", "VIEW", "INDEX_TABLE", "MATERIALIZED_VIEW"
   - classic: "TABLE", "VIEW"
   
   Are we ok with both of them?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org