You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@forrest.apache.org by "Brian Dube (JIRA)" <ji...@apache.org> on 2007/05/20 19:24:16 UTC
[jira] Created: (FOR-1000) Use locationmap to resolve XSL imports
in skins
Use locationmap to resolve XSL imports in skins
-----------------------------------------------
Key: FOR-1000
URL: https://issues.apache.org/jira/browse/FOR-1000
Project: Forrest
Issue Type: Improvement
Components: Skins (general issues)
Affects Versions: 0.8
Reporter: Brian Dube
Priority: Minor
Fix For: 0.9-dev
To create a custom skin that imports stylesheets from common, for example by copying pelt and modifying it for a project, it is also necessary to copy the common skin because the xsl:import calls use relative paths. The imports can be done with the help of the locationmap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-1000) Use locationmap to resolve XSL imports
in skins
Posted by "Brian Dube (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497311 ]
Brian Dube commented on FOR-1000:
---------------------------------
As David indicates in the surrounding thread, the custom skin documentation will need to reflect this change.
> Use locationmap to resolve XSL imports in skins
> -----------------------------------------------
>
> Key: FOR-1000
> URL: https://issues.apache.org/jira/browse/FOR-1000
> Project: Forrest
> Issue Type: Improvement
> Components: Skins (general issues)
> Affects Versions: 0.8
> Reporter: Brian Dube
> Priority: Minor
> Fix For: 0.9-dev
>
>
> To create a custom skin that imports stylesheets from common, for example by copying pelt and modifying it for a project, it is also necessary to copy the common skin because the xsl:import calls use relative paths. The imports can be done with the help of the locationmap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-1000) Use locationmap to resolve XSL imports
in skins
Posted by "Brian M Dube (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12785739#action_12785739 ]
Brian M Dube commented on FOR-1000:
-----------------------------------
The rewrites are done in r887050. I have not yet updated the documentation.
I used something like this:
$ grep -r --exclude-dir=\.svn xsl:import main/webapp/skins \
| awk -F : '{ print $1 }' \
| xargs sed -i 's_../../../common/xslt/.*/\(.*\)-to-\(.*\)\.xsl_lm://transform.skin.common.\2.\1-to-\2_'
and a slightly different version for the css. Changes to the naming scheme I used are fine by me.
There are a few files that may need to be handled separately:
$ grep -r --exclude-dir=\.svn xsl:import . | grep -v lm
./common/images/rc.svg.xslt: <xsl:import href="corner-imports.svg.xslt" />
./common/images/dc.svg.xslt: <xsl:import href="corner-imports.svg.xslt" />
./leather-dev/xslt/xml/contract.xsl: <xsl:import href="fct-bits/fct-bits.xsl"/>
./leather-dev/xslt/xml/ft-to-xhtml.xsl: <xsl:import href="fct-bits/fct-bits.xsl"/>
> Use locationmap to resolve XSL imports in skins
> -----------------------------------------------
>
> Key: FOR-1000
> URL: https://issues.apache.org/jira/browse/FOR-1000
> Project: Forrest
> Issue Type: Improvement
> Components: Skins (general issues)
> Affects Versions: 0.8
> Reporter: Brian M Dube
> Assignee: Brian M Dube
> Priority: Minor
> Fix For: 0.9-dev
>
>
> To create a custom skin that imports stylesheets from common, for example by copying pelt and modifying it for a project, it is also necessary to copy the common skin because the xsl:import calls use relative paths. The imports can be done with the help of the locationmap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-1000) Use locationmap to resolve XSL imports
in skins
Posted by "Brian M Dube (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12500994 ]
Brian M Dube commented on FOR-1000:
-----------------------------------
Example:
<xsl:import href="lm://transform.common.html.site.xhtml"/>
Cocoon generates an error for unknown protocol "lm" when I test this.
> Use locationmap to resolve XSL imports in skins
> -----------------------------------------------
>
> Key: FOR-1000
> URL: https://issues.apache.org/jira/browse/FOR-1000
> Project: Forrest
> Issue Type: Improvement
> Components: Skins (general issues)
> Affects Versions: 0.8
> Reporter: Brian M Dube
> Priority: Minor
> Fix For: 0.9-dev
>
>
> To create a custom skin that imports stylesheets from common, for example by copying pelt and modifying it for a project, it is also necessary to copy the common skin because the xsl:import calls use relative paths. The imports can be done with the help of the locationmap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (FOR-1000) Use locationmap to resolve XSL imports
in skins
Posted by "Brian M Dube (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian M Dube updated FOR-1000:
------------------------------
Affects Version/s: 0.9-dev
> Use locationmap to resolve XSL imports in skins
> -----------------------------------------------
>
> Key: FOR-1000
> URL: https://issues.apache.org/jira/browse/FOR-1000
> Project: Forrest
> Issue Type: Improvement
> Components: Skins (general issues)
> Affects Versions: 0.8, 0.9-dev
> Reporter: Brian M Dube
> Assignee: Brian M Dube
> Priority: Minor
> Fix For: 0.9-dev
>
>
> To create a custom skin that imports stylesheets from common, for example by copying pelt and modifying it for a project, it is also necessary to copy the common skin because the xsl:import calls use relative paths. The imports can be done with the help of the locationmap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (FOR-1000) Use locationmap to resolve XSL imports in
skins
Posted by "Brian M Dube (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian M Dube closed FOR-1000.
-----------------------------
Resolution: Fixed
Assignee: (was: Brian M Dube)
Please review the locationmap naming scheme and documentation changes.
> Use locationmap to resolve XSL imports in skins
> -----------------------------------------------
>
> Key: FOR-1000
> URL: https://issues.apache.org/jira/browse/FOR-1000
> Project: Forrest
> Issue Type: Improvement
> Components: Skins (general issues)
> Affects Versions: 0.8, 0.9-dev
> Reporter: Brian M Dube
> Priority: Minor
> Fix For: 0.9-dev
>
>
> To create a custom skin that imports stylesheets from common, for example by copying pelt and modifying it for a project, it is also necessary to copy the common skin because the xsl:import calls use relative paths. The imports can be done with the help of the locationmap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (FOR-1000) Use locationmap to resolve
XSL imports in skins
Posted by "Brian M Dube (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780418#action_12780418 ]
Brian M Dube edited comment on FOR-1000 at 12/1/09 3:56 AM:
------------------------------------------------------------
I just made a quick test and it worked.
Next:
1) Devise a naming scheme for main/webapp/locationmap-transforms.xml
2) Replace all the relative skin imports with the locationmap pattern from step 1
3) Update documentation regarding custom skins
If I don't get to it by tomorrow evening, it'll be a few weeks before I can.
was (Author: brian):
I just made a quick test and it worked.
Next:
1) Devise a naming scheme for main/webapp/locationmap-transforms.xml
2) Replace all the relative skin imports with the locationmap pattern from step 1
If I don't get to it by tomorrow evening, it'll be a few weeks before I can.
> Use locationmap to resolve XSL imports in skins
> -----------------------------------------------
>
> Key: FOR-1000
> URL: https://issues.apache.org/jira/browse/FOR-1000
> Project: Forrest
> Issue Type: Improvement
> Components: Skins (general issues)
> Affects Versions: 0.8
> Reporter: Brian M Dube
> Assignee: Brian M Dube
> Priority: Minor
> Fix For: 0.9-dev
>
>
> To create a custom skin that imports stylesheets from common, for example by copying pelt and modifying it for a project, it is also necessary to copy the common skin because the xsl:import calls use relative paths. The imports can be done with the help of the locationmap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (FOR-1000) Use locationmap to resolve XSL imports
in skins
Posted by "Brian M Dube (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Brian M Dube reassigned FOR-1000:
---------------------------------
Assignee: Brian M Dube
> Use locationmap to resolve XSL imports in skins
> -----------------------------------------------
>
> Key: FOR-1000
> URL: https://issues.apache.org/jira/browse/FOR-1000
> Project: Forrest
> Issue Type: Improvement
> Components: Skins (general issues)
> Affects Versions: 0.8
> Reporter: Brian M Dube
> Assignee: Brian M Dube
> Priority: Minor
> Fix For: 0.9-dev
>
>
> To create a custom skin that imports stylesheets from common, for example by copying pelt and modifying it for a project, it is also necessary to copy the common skin because the xsl:import calls use relative paths. The imports can be done with the help of the locationmap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-1000) Use locationmap to resolve XSL imports
in skins
Posted by "Brian M Dube (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780418#action_12780418 ]
Brian M Dube commented on FOR-1000:
-----------------------------------
I just made a quick test and it worked.
Next:
1) Devise a naming scheme for main/webapp/locationmap-transforms.xml
2) Replace all the relative skin imports with the locationmap pattern from step 1
If I don't get to it by tomorrow evening, it'll be a few weeks before I can.
> Use locationmap to resolve XSL imports in skins
> -----------------------------------------------
>
> Key: FOR-1000
> URL: https://issues.apache.org/jira/browse/FOR-1000
> Project: Forrest
> Issue Type: Improvement
> Components: Skins (general issues)
> Affects Versions: 0.8
> Reporter: Brian M Dube
> Priority: Minor
> Fix For: 0.9-dev
>
>
> To create a custom skin that imports stylesheets from common, for example by copying pelt and modifying it for a project, it is also necessary to copy the common skin because the xsl:import calls use relative paths. The imports can be done with the help of the locationmap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-1000) Use locationmap to resolve XSL imports
in skins
Posted by "Tim Williams (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12780334#action_12780334 ]
Tim Williams commented on FOR-1000:
-----------------------------------
So with the new LocationmapSourceFactory is this not resolved?
> Use locationmap to resolve XSL imports in skins
> -----------------------------------------------
>
> Key: FOR-1000
> URL: https://issues.apache.org/jira/browse/FOR-1000
> Project: Forrest
> Issue Type: Improvement
> Components: Skins (general issues)
> Affects Versions: 0.8
> Reporter: Brian M Dube
> Priority: Minor
> Fix For: 0.9-dev
>
>
> To create a custom skin that imports stylesheets from common, for example by copying pelt and modifying it for a project, it is also necessary to copy the common skin because the xsl:import calls use relative paths. The imports can be done with the help of the locationmap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (FOR-1000) Use locationmap to resolve XSL imports
in skins
Posted by "Brian Dube (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/FOR-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12497270 ]
Brian Dube commented on FOR-1000:
---------------------------------
Some discussion:
http://www.mail-archive.com/user@forrest.apache.org/msg02741.html
> Use locationmap to resolve XSL imports in skins
> -----------------------------------------------
>
> Key: FOR-1000
> URL: https://issues.apache.org/jira/browse/FOR-1000
> Project: Forrest
> Issue Type: Improvement
> Components: Skins (general issues)
> Affects Versions: 0.8
> Reporter: Brian Dube
> Priority: Minor
> Fix For: 0.9-dev
>
>
> To create a custom skin that imports stylesheets from common, for example by copying pelt and modifying it for a project, it is also necessary to copy the common skin because the xsl:import calls use relative paths. The imports can be done with the help of the locationmap.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.