You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by "vdombrovski (via GitHub)" <gi...@apache.org> on 2023/09/15 09:20:16 UTC

[GitHub] [cloudstack-terraform-provider] vdombrovski opened a new issue, #72: Support hot resize of disk

vdombrovski opened a new issue, #72:
URL: https://github.com/apache/cloudstack-terraform-provider/issues/72

   Currently, whenever the size of a volume changes, the disk gets detached before resizing. 
   
   https://github.com/apache/cloudstack-terraform-provider/blob/main/cloudstack/resource_cloudstack_disk.go#L217
   
   However Cloudstack 4.17 supports dynamic data disk resising without detaching it, which means we don't always need to detach / attach disk in certain cases (e.g. when only size changes). It would be cool to have this feature in the TF provider as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support hot resize of disk [cloudstack-terraform-provider]

Posted by "btzq (via GitHub)" <gi...@apache.org>.
btzq commented on issue #72:
URL: https://github.com/apache/cloudstack-terraform-provider/issues/72#issuecomment-2030018473

   Hi There, 
   
   When we resize a disk, we noticed that although terraform says its 'modified', in reality, Terraform will unmount, destroy the volume, recreate a new one. (We have to manually reattach it back after). 
   
   Will his fix resolve this as well?
   
   Also, can terraform mount a volume for us automatically? Or do we have to manually mount it oureselves all the time?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support hot resize of disk [cloudstack-terraform-provider]

Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on issue #72:
URL: https://github.com/apache/cloudstack-terraform-provider/issues/72#issuecomment-1978593625

   @vdombrovski 
   
   I have cross-checked the issue and disk resize is happening when you use a custom disk offering
   
   ![Screenshot 2024-03-05 at 5 24 01 PM](https://github.com/apache/cloudstack-terraform-provider/assets/1401014/dee7763c-e127-4db8-812b-9404010d4f55)
   
   
   
   Terraform is performing the  resize operation :
   
   ```
     # cloudstack_disk.test-disk will be updated in-place
     ~ resource "cloudstack_disk" "test-disk" {
           id                 = "d5a695d5-7bd7-46f8-b63f-be81152584bf"
           name               = "test-disk"
         ~ size               = 5 -> 10
           tags               = {}
           # (6 unchanged attributes hidden)
       }
   ```
       
       
   
   Please make sure to use a custom disk offering
   
   ```
   resource "cloudstack_disk" "default" {
     name               = "test-disk"
     attach             = "true"
     disk_offering      = "custom"
     size               = 50
     virtual_machine_id = "server-1"
     zone               = "zone-1"
   }
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support hot resize of disk [cloudstack-terraform-provider]

Posted by "vishesh92 (via GitHub)" <gi...@apache.org>.
vishesh92 closed issue #72: Support hot resize of disk
URL: https://github.com/apache/cloudstack-terraform-provider/issues/72


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support hot resize of disk [cloudstack-terraform-provider]

Posted by "kiranchavala (via GitHub)" <gi...@apache.org>.
kiranchavala commented on issue #72:
URL: https://github.com/apache/cloudstack-terraform-provider/issues/72#issuecomment-2031052796

   @btzq 
   
   Yes with fix  the resize job  will be done without any detach operation.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [I] Support hot resize of disk [cloudstack-terraform-provider]

Posted by "btzq (via GitHub)" <gi...@apache.org>.
btzq commented on issue #72:
URL: https://github.com/apache/cloudstack-terraform-provider/issues/72#issuecomment-2031116052

   @kiranchavala great! Cant wait to test it in V0.5!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org