You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2019/05/25 00:08:41 UTC

[GitHub] [mynewt-newt] ccollins476ad commented on issue #299: Add ed25519 signing support

ccollins476ad commented on issue #299: Add ed25519 signing support
URL: https://github.com/apache/mynewt-newt/pull/299#issuecomment-495817522
 
 
   Looks good to me.  I think the `go.mod` and `go.sum` files need to be updated.  This should do the trick:
   
   ```
   rm go.mod go.sum
   GO111MODULE=on go mod init
   cd newt
   GO111MODULE=on go build
   ```
   
   This is not the usual way to update these files, but since you already updated the `Gopkg.[...]` files, it is easier to rebuild the `go.[...]` files from them.
   
   We should remove `Gopkg.lock` and `Gopkg.toml` to avoid confusion, but that can happen in a different PR.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services