You are viewing a plain text version of this content. The canonical link for it is here.
Posted to users@wicket.apache.org by Thorsten Schöning <ts...@am-soft.de> on 2016/03/30 15:55:31 UTC

Failing locale dependent tests in wicket-core

Hi,

I'm building wicket 7.3.0.0 SNAPSHOT in Ubuntu 12.04 LTS and have the
following failed tests:

> Failed tests:
>  MinifiedAwareResourceReferenceTest.minifiedResourceAvailable:61->Assert.assertEquals:144->Assert.assertEquals:115 expected:<// b[.min].js> but was:<// b[_de].js>
>  ResouceBundleTest.concatBundle:48->Assert.assertEquals:144->Assert.assertEquals:115 expected:<//a// b[].js> but was:<//a// b[_de].js>
>  ResourceReferenceLocatingTest.locateMinifiedJavaScriptResourceReference:214->checkNonStrictUsingJavaScriptResourceReference:236->Assert.assertThat:956 TestCase [locale=null, style=null, variation=null, extension=null]
> Expected: is "// b.min.js"
>     but: was "// b_de.js"
>  ResourceReferenceLocatingTest.locateMinifiedPackageResourceReference:223->checkNonStrictUsingPackageResourceReference:250->Assert.assertThat:956 TestCase [locale=null, style=null, variation=null, extension=null]
> Expected: is "// b.min.js"
>     but: was "// b_de.js"
>  ResourceReferenceLocatingTest.locateNonMinifiedJavaScriptResourceReference:196->checkNonStrictUsingJavaScriptResourceReference:236->Assert.assertThat:956 TestCase [locale=null, style=null, variation=null, extension=null]
> Expected: is "// b.js"
>     but: was "// b_de.js"
>  ResourceReferenceLocatingTest.locateNonMinifiedPackageResourceReference:205->checkNonStrictUsingPackageResourceReference:250->Assert.assertThat:956 TestCase [locale=null, style=null, variation=null, extension=null]
> Expected: is "// b.js"
>     but: was "// b_de.js"
     
> Tests run: 1947, Failures: 6, Errors: 0, Skipped: 1

This fails for different versions of maven all starting with an empty
.m2 folder:

> Apache Maven 3.0.4
> Maven home: /usr/share/maven
> Java version: 1.7.0_95, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-7-openjdk-amd64/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "linux", version: "3.13.0-83-generic", arch: "amd64", family: "unix"

> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00)
> Maven home: /home/tschoening/apache-maven-3.3.9
> [like before]

In one of the tests I find the following comment:

> // this will try 3 lookups for minified resources: en_US.min, en.min and .min

My locale is de_DE, so is this simply not supported or is this a bug
in the tests?

Mit freundlichen Grüßen,

Thorsten Schöning

-- 
Thorsten Schöning       E-Mail: Thorsten.Schoening@AM-SoFT.de
AM-SoFT IT-Systeme      http://www.AM-SoFT.de/

Telefon...........05151-  9468- 55
Fax...............05151-  9468- 88
Mobil..............0178-8 9468- 04

AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln
AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org


Re: Failing locale dependent tests in wicket-core

Posted by Tobias Soloschenko <to...@googlemail.com>.
Nice! Thanks Martin!

kind regards

Tobias

Am 30.03.16 um 16:32 schrieb Martin Grigorov:
> Fixed it!
> Thanks!
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Wed, Mar 30, 2016 at 3:59 PM, Martin Grigorov <mg...@apache.org>
> wrote:
>
>> I've pasted the same output in your other thread about the issue in the
>> Spring related test.
>>
>> It is a bug in the tests.
>> If a test expects to see _en in the result then it should make sure the
>> session locale is EN.
>>
>> I build Wicket with bg_BG all the time but those tests do not fail in that
>> case :-/
>>
>> Martin Grigorov
>> Wicket Training and Consulting
>> https://twitter.com/mtgrigorov
>>
>> On Wed, Mar 30, 2016 at 3:55 PM, Thorsten Schöning <ts...@am-soft.de>
>> wrote:
>>
>>> Hi,
>>>
>>> I'm building wicket 7.3.0.0 SNAPSHOT in Ubuntu 12.04 LTS and have the
>>> following failed tests:
>>>
>>>> Failed tests:
>>>>
>>> MinifiedAwareResourceReferenceTest.minifiedResourceAvailable:61->Assert.assertEquals:144->Assert.assertEquals:115
>>> expected:<// b[.min].js> but was:<// b[_de].js>
>>> ResouceBundleTest.concatBundle:48->Assert.assertEquals:144->Assert.assertEquals:115
>>> expected:<//a// b[].js> but was:<//a// b[_de].js>
>>> ResourceReferenceLocatingTest.locateMinifiedJavaScriptResourceReference:214->checkNonStrictUsingJavaScriptResourceReference:236->Assert.assertThat:956
>>> TestCase [locale=null, style=null, variation=null, extension=null]
>>>> Expected: is "// b.min.js"
>>>>      but: was "// b_de.js"
>>>>
>>> ResourceReferenceLocatingTest.locateMinifiedPackageResourceReference:223->checkNonStrictUsingPackageResourceReference:250->Assert.assertThat:956
>>> TestCase [locale=null, style=null, variation=null, extension=null]
>>>> Expected: is "// b.min.js"
>>>>      but: was "// b_de.js"
>>>>
>>> ResourceReferenceLocatingTest.locateNonMinifiedJavaScriptResourceReference:196->checkNonStrictUsingJavaScriptResourceReference:236->Assert.assertThat:956
>>> TestCase [locale=null, style=null, variation=null, extension=null]
>>>> Expected: is "// b.js"
>>>>      but: was "// b_de.js"
>>>>
>>> ResourceReferenceLocatingTest.locateNonMinifiedPackageResourceReference:205->checkNonStrictUsingPackageResourceReference:250->Assert.assertThat:956
>>> TestCase [locale=null, style=null, variation=null, extension=null]
>>>> Expected: is "// b.js"
>>>>      but: was "// b_de.js"
>>>> Tests run: 1947, Failures: 6, Errors: 0, Skipped: 1
>>> This fails for different versions of maven all starting with an empty
>>> .m2 folder:
>>>
>>>> Apache Maven 3.0.4
>>>> Maven home: /usr/share/maven
>>>> Java version: 1.7.0_95, vendor: Oracle Corporation
>>>> Java home: /usr/lib/jvm/java-7-openjdk-amd64/jre
>>>> Default locale: de_DE, platform encoding: UTF-8
>>>> OS name: "linux", version: "3.13.0-83-generic", arch: "amd64", family:
>>> "unix"
>>>
>>>> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
>>> 2015-11-10T17:41:47+01:00)
>>>> Maven home: /home/tschoening/apache-maven-3.3.9
>>>> [like before]
>>> In one of the tests I find the following comment:
>>>
>>>> // this will try 3 lookups for minified resources: en_US.min, en.min
>>> and .min
>>>
>>> My locale is de_DE, so is this simply not supported or is this a bug
>>> in the tests?
>>>
>>> Mit freundlichen Grüßen,
>>>
>>> Thorsten Schöning
>>>
>>> --
>>> Thorsten Schöning       E-Mail: Thorsten.Schoening@AM-SoFT.de
>>> AM-SoFT IT-Systeme      http://www.AM-SoFT.de/
>>>
>>> Telefon...........05151-  9468- 55
>>> Fax...............05151-  9468- 88
>>> Mobil..............0178-8 9468- 04
>>>
>>> AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln
>>> AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>>> For additional commands, e-mail: users-help@wicket.apache.org
>>>
>>>


---------------------------------------------------------------------
To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
For additional commands, e-mail: users-help@wicket.apache.org


Re: Failing locale dependent tests in wicket-core

Posted by Martin Grigorov <mg...@apache.org>.
Fixed it!
Thanks!

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Wed, Mar 30, 2016 at 3:59 PM, Martin Grigorov <mg...@apache.org>
wrote:

> I've pasted the same output in your other thread about the issue in the
> Spring related test.
>
> It is a bug in the tests.
> If a test expects to see _en in the result then it should make sure the
> session locale is EN.
>
> I build Wicket with bg_BG all the time but those tests do not fail in that
> case :-/
>
> Martin Grigorov
> Wicket Training and Consulting
> https://twitter.com/mtgrigorov
>
> On Wed, Mar 30, 2016 at 3:55 PM, Thorsten Schöning <ts...@am-soft.de>
> wrote:
>
>> Hi,
>>
>> I'm building wicket 7.3.0.0 SNAPSHOT in Ubuntu 12.04 LTS and have the
>> following failed tests:
>>
>> > Failed tests:
>> >
>> MinifiedAwareResourceReferenceTest.minifiedResourceAvailable:61->Assert.assertEquals:144->Assert.assertEquals:115
>> expected:<// b[.min].js> but was:<// b[_de].js>
>> >
>> ResouceBundleTest.concatBundle:48->Assert.assertEquals:144->Assert.assertEquals:115
>> expected:<//a// b[].js> but was:<//a// b[_de].js>
>> >
>> ResourceReferenceLocatingTest.locateMinifiedJavaScriptResourceReference:214->checkNonStrictUsingJavaScriptResourceReference:236->Assert.assertThat:956
>> TestCase [locale=null, style=null, variation=null, extension=null]
>> > Expected: is "// b.min.js"
>> >     but: was "// b_de.js"
>> >
>> ResourceReferenceLocatingTest.locateMinifiedPackageResourceReference:223->checkNonStrictUsingPackageResourceReference:250->Assert.assertThat:956
>> TestCase [locale=null, style=null, variation=null, extension=null]
>> > Expected: is "// b.min.js"
>> >     but: was "// b_de.js"
>> >
>> ResourceReferenceLocatingTest.locateNonMinifiedJavaScriptResourceReference:196->checkNonStrictUsingJavaScriptResourceReference:236->Assert.assertThat:956
>> TestCase [locale=null, style=null, variation=null, extension=null]
>> > Expected: is "// b.js"
>> >     but: was "// b_de.js"
>> >
>> ResourceReferenceLocatingTest.locateNonMinifiedPackageResourceReference:205->checkNonStrictUsingPackageResourceReference:250->Assert.assertThat:956
>> TestCase [locale=null, style=null, variation=null, extension=null]
>> > Expected: is "// b.js"
>> >     but: was "// b_de.js"
>>
>> > Tests run: 1947, Failures: 6, Errors: 0, Skipped: 1
>>
>> This fails for different versions of maven all starting with an empty
>> .m2 folder:
>>
>> > Apache Maven 3.0.4
>> > Maven home: /usr/share/maven
>> > Java version: 1.7.0_95, vendor: Oracle Corporation
>> > Java home: /usr/lib/jvm/java-7-openjdk-amd64/jre
>> > Default locale: de_DE, platform encoding: UTF-8
>> > OS name: "linux", version: "3.13.0-83-generic", arch: "amd64", family:
>> "unix"
>>
>> > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
>> 2015-11-10T17:41:47+01:00)
>> > Maven home: /home/tschoening/apache-maven-3.3.9
>> > [like before]
>>
>> In one of the tests I find the following comment:
>>
>> > // this will try 3 lookups for minified resources: en_US.min, en.min
>> and .min
>>
>> My locale is de_DE, so is this simply not supported or is this a bug
>> in the tests?
>>
>> Mit freundlichen Grüßen,
>>
>> Thorsten Schöning
>>
>> --
>> Thorsten Schöning       E-Mail: Thorsten.Schoening@AM-SoFT.de
>> AM-SoFT IT-Systeme      http://www.AM-SoFT.de/
>>
>> Telefon...........05151-  9468- 55
>> Fax...............05151-  9468- 88
>> Mobil..............0178-8 9468- 04
>>
>> AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln
>> AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
>> For additional commands, e-mail: users-help@wicket.apache.org
>>
>>
>

Re: Failing locale dependent tests in wicket-core

Posted by Martin Grigorov <mg...@apache.org>.
I've pasted the same output in your other thread about the issue in the
Spring related test.

It is a bug in the tests.
If a test expects to see _en in the result then it should make sure the
session locale is EN.

I build Wicket with bg_BG all the time but those tests do not fail in that
case :-/

Martin Grigorov
Wicket Training and Consulting
https://twitter.com/mtgrigorov

On Wed, Mar 30, 2016 at 3:55 PM, Thorsten Schöning <ts...@am-soft.de>
wrote:

> Hi,
>
> I'm building wicket 7.3.0.0 SNAPSHOT in Ubuntu 12.04 LTS and have the
> following failed tests:
>
> > Failed tests:
> >
> MinifiedAwareResourceReferenceTest.minifiedResourceAvailable:61->Assert.assertEquals:144->Assert.assertEquals:115
> expected:<// b[.min].js> but was:<// b[_de].js>
> >
> ResouceBundleTest.concatBundle:48->Assert.assertEquals:144->Assert.assertEquals:115
> expected:<//a// b[].js> but was:<//a// b[_de].js>
> >
> ResourceReferenceLocatingTest.locateMinifiedJavaScriptResourceReference:214->checkNonStrictUsingJavaScriptResourceReference:236->Assert.assertThat:956
> TestCase [locale=null, style=null, variation=null, extension=null]
> > Expected: is "// b.min.js"
> >     but: was "// b_de.js"
> >
> ResourceReferenceLocatingTest.locateMinifiedPackageResourceReference:223->checkNonStrictUsingPackageResourceReference:250->Assert.assertThat:956
> TestCase [locale=null, style=null, variation=null, extension=null]
> > Expected: is "// b.min.js"
> >     but: was "// b_de.js"
> >
> ResourceReferenceLocatingTest.locateNonMinifiedJavaScriptResourceReference:196->checkNonStrictUsingJavaScriptResourceReference:236->Assert.assertThat:956
> TestCase [locale=null, style=null, variation=null, extension=null]
> > Expected: is "// b.js"
> >     but: was "// b_de.js"
> >
> ResourceReferenceLocatingTest.locateNonMinifiedPackageResourceReference:205->checkNonStrictUsingPackageResourceReference:250->Assert.assertThat:956
> TestCase [locale=null, style=null, variation=null, extension=null]
> > Expected: is "// b.js"
> >     but: was "// b_de.js"
>
> > Tests run: 1947, Failures: 6, Errors: 0, Skipped: 1
>
> This fails for different versions of maven all starting with an empty
> .m2 folder:
>
> > Apache Maven 3.0.4
> > Maven home: /usr/share/maven
> > Java version: 1.7.0_95, vendor: Oracle Corporation
> > Java home: /usr/lib/jvm/java-7-openjdk-amd64/jre
> > Default locale: de_DE, platform encoding: UTF-8
> > OS name: "linux", version: "3.13.0-83-generic", arch: "amd64", family:
> "unix"
>
> > Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
> 2015-11-10T17:41:47+01:00)
> > Maven home: /home/tschoening/apache-maven-3.3.9
> > [like before]
>
> In one of the tests I find the following comment:
>
> > // this will try 3 lookups for minified resources: en_US.min, en.min and
> .min
>
> My locale is de_DE, so is this simply not supported or is this a bug
> in the tests?
>
> Mit freundlichen Grüßen,
>
> Thorsten Schöning
>
> --
> Thorsten Schöning       E-Mail: Thorsten.Schoening@AM-SoFT.de
> AM-SoFT IT-Systeme      http://www.AM-SoFT.de/
>
> Telefon...........05151-  9468- 55
> Fax...............05151-  9468- 88
> Mobil..............0178-8 9468- 04
>
> AM-SoFT GmbH IT-Systeme, Brandenburger Str. 7c, 31789 Hameln
> AG Hannover HRB 207 694 - Geschäftsführer: Andreas Muchow
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: users-unsubscribe@wicket.apache.org
> For additional commands, e-mail: users-help@wicket.apache.org
>
>