You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/18 09:37:01 UTC
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #15873: [feature](cooldown) Decouple storage policy and resource
github-actions[bot] commented on code in PR #15873:
URL: https://github.com/apache/doris/pull/15873#discussion_r1073299927
##########
be/test/olap/tablet_test.cpp:
##########
@@ -313,7 +312,8 @@ TEST_F(TestTablet, cooldown_policy) {
TabletSharedPtr _tablet(new Tablet(_tablet_meta, nullptr));
_tablet->init();
- _tablet->set_storage_policy("test_policy_name");
+ constexpr int64_t storage_policy_id = 10000;
+ _tablet->set_storage_policy_id(storage_policy_id);
_tablet->_rs_version_map[ptr1->version()] = rowset1;
Review Comment:
warning: '_rs_version_map' is a private member of 'doris::Tablet' [clang-diagnostic-error]
```cpp
_tablet->_rs_version_map[ptr1->version()] = rowset1;
^
```
**be/src/olap/tablet.h:414:** declared private here
```cpp
std::unordered_map<Version, RowsetSharedPtr, HashOfVersion> _rs_version_map;
^
```
##########
be/test/olap/remote_rowset_gc_test.cpp:
##########
@@ -54,7 +55,12 @@ class RemoteRowsetGcTest : public testing::Test {
s3_conf.prefix = "remote_rowset_gc_test";
auto s3_fs = io::S3FileSystem::create(std::move(s3_conf), kResourceId);
Review Comment:
warning: no viable conversion from 'const int64_t' (aka 'const long') to 'std::string' (aka 'basic_string<char>') [clang-diagnostic-error]
```cpp
auto s3_fs = io::S3FileSystem::create(std::move(s3_conf), kResourceId);
^
```
**/usr/include/c++/11/bits/basic_string.h:455:** candidate constructor not viable: no known conversion from 'const int64_t' (aka 'const long') to 'const std::basic_string<char> &' for 1st argument
```cpp
basic_string(const basic_string& __str)
^
```
**/usr/include/c++/11/bits/basic_string.h:532:** candidate constructor template not viable: no known conversion from 'const int64_t' (aka 'const long') to 'const char *' for 1st argument
```cpp
basic_string(const _CharT* __s, const _Alloc& __a = _Alloc())
^
```
**/usr/include/c++/11/bits/basic_string.h:564:** candidate constructor not viable: no known conversion from 'const int64_t' (aka 'const long') to 'std::basic_string<char> &&' for 1st argument
```cpp
basic_string(basic_string&& __str) noexcept
^
```
**/usr/include/c++/11/bits/basic_string.h:591:** candidate constructor not viable: no known conversion from 'const int64_t' (aka 'const long') to 'initializer_list<char>' for 1st argument
```cpp
basic_string(initializer_list<_CharT> __l, const _Alloc& __a = _Alloc())
^
```
**/usr/include/c++/11/bits/basic_string.h:447:** explicit constructor is not a candidate
```cpp
basic_string(const _Alloc& __a) _GLIBCXX_NOEXCEPT
^
```
**/usr/include/c++/11/bits/basic_string.h:663:** explicit constructor is not a candidate
```cpp
basic_string(const _Tp& __t, const _Alloc& __a = _Alloc())
^
```
**be/src/io/fs/s3_file_system.h:37:** passing argument to parameter 'id' here
```cpp
static std::shared_ptr<S3FileSystem> create(S3Conf s3_conf, std::string id);
^
```
##########
be/test/olap/tablet_test.cpp:
##########
@@ -313,7 +312,8 @@
TabletSharedPtr _tablet(new Tablet(_tablet_meta, nullptr));
_tablet->init();
- _tablet->set_storage_policy("test_policy_name");
+ constexpr int64_t storage_policy_id = 10000;
+ _tablet->set_storage_policy_id(storage_policy_id);
_tablet->_rs_version_map[ptr1->version()] = rowset1;
_tablet->_rs_version_map[ptr2->version()] = rowset2;
Review Comment:
warning: '_rs_version_map' is a private member of 'doris::Tablet' [clang-diagnostic-error]
```cpp
_tablet->_rs_version_map[ptr2->version()] = rowset2;
^
```
**be/src/olap/tablet.h:414:** declared private here
```cpp
std::unordered_map<Version, RowsetSharedPtr, HashOfVersion> _rs_version_map;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org