[GitHub] [arrow-rs] alamb commented on issue #101: min and max aggregate kernels are inconsistent for floating point types.

[GitBox <gi...@apache.org>]

alamb commented on issue #101:
URL: https://github.com/apache/arrow-rs/issues/101#issuecomment-1054619612


   I think so. Thank you @HaoYang670 
   
   Just to be sure, I tried the reproducer from the original ticket https://issues.apache.org/jira/browse/ARROW-9975
   
   ```rust
   use arrow::{
       datatypes::Float64Type,
       compute::kernels::aggregate::min,
       array::{
           PrimitiveBuilder
       }
   };
   
   pub fn main() {
       let mut builder_1 = PrimitiveBuilder::<Float64Type>::new(2);
       builder_1.append_value(1.0).unwrap();
       builder_1.append_value(f64::NAN).unwrap();
       let array_1 = builder_1.finish();
   
       let mut builder_2 = PrimitiveBuilder::<Float64Type>::new(2);
       builder_2.append_value(f64::NAN).unwrap();
       builder_2.append_value(1.0).unwrap();
       let array_2 = builder_2.finish();
   
       // expect both nan, or both 1.0
       assert_eq!(min(&array_1), min(&array_2));
       println!("done!");
   }
   ```
   
   And it prints out:
   ```shell
   -*- mode: compilation; default-directory: "~/Software/rust_arrow_playground/" -*-
   Compilation started at Mon Feb 28 15:09:19
   
   cd ~/Software/rust_arrow_playground/ && cargo run
      Compiling rust_arrow_playground v0.1.0 (/Users/alamb/Software/rust_arrow_playground)
       Finished dev [unoptimized + debuginfo] target(s) in 0.72s
        Running `target/debug/rust_arrow_playground`
   done!
   
   Compilation finished at Mon Feb 28 15:09:20
   
   ```
   
   cc @jorgecarleitao  and @ritchie46 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org