You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/26 01:51:40 UTC
[GitHub] [pulsar-helm-chart] sijie opened a new pull request #28: Don't substitute environment variables
sijie opened a new pull request #28:
URL: https://github.com/apache/pulsar-helm-chart/pull/28
*Motivation*
environment variables are already taken by bash scripts. We don't need to substitute them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] rvashishth commented on pull request #28: Don't substitute environment variables
Posted by GitBox <gi...@apache.org>.
rvashishth commented on pull request #28:
URL: https://github.com/apache/pulsar-helm-chart/pull/28#issuecomment-650097751
@sijie would it be worth to keep updating the [chart version](https://github.com/apache/pulsar-helm-chart/blob/master/charts/pulsar/Chart.yaml#L24) as mentioned in [helm docs](https://helm.sh/docs/topics/charts/#charts-and-versioning), with each PR merge.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] sijie merged pull request #28: Don't substitute environment variables
Posted by GitBox <gi...@apache.org>.
sijie merged pull request #28:
URL: https://github.com/apache/pulsar-helm-chart/pull/28
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [pulsar-helm-chart] sijie commented on pull request #28: Don't substitute environment variables
Posted by GitBox <gi...@apache.org>.
sijie commented on pull request #28:
URL: https://github.com/apache/pulsar-helm-chart/pull/28#issuecomment-650265327
@rvashishth #21 is for releasing charts. we bump the chart version when releasing a version.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org