You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/10/19 03:41:19 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #34322: [SPARK-37052][CORE] Spark should only pass --verbose argument to main class when is sql shell
AngersZhuuuu opened a new pull request #34322:
URL: https://github.com/apache/spark/pull/34322
### What changes were proposed in this pull request?
In https://github.com/apache/spark/pull/32163 spark pass `--verbose` to main class o support spark-sql shell can use verbose argument too.
But for other shell main class such as saprk-shell, it's intercepter don't support `--verbose`, so we should only pass `--verbose` for sql shell
### Why are the changes needed?
Fix bug
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34322: [SPARK-37052][CORE] Spark should only pass --verbose argument to main class when is sql shell
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34322:
URL: https://github.com/apache/spark/pull/34322#issuecomment-946408460
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48865/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34322: [SPARK-37052][CORE] Spark should only pass --verbose argument to main class when is sql shell
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34322:
URL: https://github.com/apache/spark/pull/34322#issuecomment-946443503
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144391/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34322: [SPARK-37052][CORE] Spark should only pass --verbose argument to main class when is sql shell
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34322:
URL: https://github.com/apache/spark/pull/34322#issuecomment-946376340
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48865/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #34322: [SPARK-37052][CORE] Spark should only pass --verbose argument to main class when is sql shell
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #34322:
URL: https://github.com/apache/spark/pull/34322#issuecomment-946341872
ping @cloud-fan @HyukjinKwon @yaooqinn @LuciferYang
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34322: [SPARK-37052][CORE] Spark should only pass --verbose argument to main class when is sql shell
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34322:
URL: https://github.com/apache/spark/pull/34322#issuecomment-946401675
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/48865/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #34322: [SPARK-37052][CORE] Spark should only pass --verbose argument to main class when is sql shell
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #34322:
URL: https://github.com/apache/spark/pull/34322#issuecomment-946342895
@toujours33 pick this to our branch to verify it please, thanks ~
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #34322: [SPARK-37052][CORE] Spark should only pass --verbose argument to main class when is sql shell
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #34322:
URL: https://github.com/apache/spark/pull/34322#issuecomment-946342517
**[Test build #144391 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144391/testReport)** for PR 34322 at commit [`c314b5d`](https://github.com/apache/spark/commit/c314b5d534793b5aef5cdce50a909d42e07d54e0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #34322: [SPARK-37052][CORE] Spark should only pass --verbose argument to main class when is sql shell
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #34322:
URL: https://github.com/apache/spark/pull/34322#issuecomment-946443503
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/144391/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang edited a comment on pull request #34322: [SPARK-37052][CORE] Spark should only pass --verbose argument to main class when is sql shell
Posted by GitBox <gi...@apache.org>.
LuciferYang edited a comment on pull request #34322:
URL: https://github.com/apache/spark/pull/34322#issuecomment-946342895
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #34322: [SPARK-37052][CORE] Spark should only pass --verbose argument to main class when is sql shell
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #34322:
URL: https://github.com/apache/spark/pull/34322#issuecomment-946411161
thanks, merging to master/3.2!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #34322: [SPARK-37052][CORE] Spark should only pass --verbose argument to main class when is sql shell
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #34322:
URL: https://github.com/apache/spark/pull/34322
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #34322: [SPARK-37052][CORE] Spark should only pass --verbose argument to main class when is sql shell
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #34322:
URL: https://github.com/apache/spark/pull/34322#issuecomment-946437479
+1, LGTM
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34322: [SPARK-37052][CORE] Spark should only pass --verbose argument to main class when is sql shell
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34322:
URL: https://github.com/apache/spark/pull/34322#issuecomment-946422624
**[Test build #144391 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144391/testReport)** for PR 34322 at commit [`c314b5d`](https://github.com/apache/spark/commit/c314b5d534793b5aef5cdce50a909d42e07d54e0).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #34322: [SPARK-37052][CORE] Spark should only pass --verbose argument to main class when is sql shell
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #34322:
URL: https://github.com/apache/spark/pull/34322#issuecomment-946342517
**[Test build #144391 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/144391/testReport)** for PR 34322 at commit [`c314b5d`](https://github.com/apache/spark/commit/c314b5d534793b5aef5cdce50a909d42e07d54e0).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] LuciferYang commented on pull request #34322: [SPARK-37052][CORE] Spark should only pass --verbose argument to main class when is sql shell
Posted by GitBox <gi...@apache.org>.
LuciferYang commented on pull request #34322:
URL: https://github.com/apache/spark/pull/34322#issuecomment-946342895
@toujours33 let us pick this to our branch to verify it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #34322: [SPARK-37052][CORE] Spark should only pass --verbose argument to main class when is sql shell
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #34322:
URL: https://github.com/apache/spark/pull/34322#issuecomment-946408460
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/48865/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org