You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Andrew Sherman (Code Review)" <ge...@cloudera.org> on 2021/12/01 17:25:13 UTC
[Impala-ASF-CR] IMPALA-10764: hide /logs link in webui if --logtostderr=true
Andrew Sherman has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18062
Change subject: IMPALA-10764: hide /logs link in webui if --logtostderr=true
......................................................................
IMPALA-10764: hide /logs link in webui if --logtostderr=true
If you start an Impala daemon with the flags
"--logtostderr=true --redirect_stdout_stderr=false"
then log files are not created. After this the webui will display an
error if you click on the "/logs" link. Fix this by not adding
the "/logs" link in this case.
TESTING
- Added a new test that validates the navbar links in the webui.
- Ran exhaustive tests
Change-Id: I65234213f32902caa1f4368181b49f012a4dbcb3
---
M be/src/util/default-path-handlers.cc
M tests/custom_cluster/test_web_pages.py
2 files changed, 71 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/62/18062/1
--
To view, visit http://gerrit.cloudera.org:8080/18062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I65234213f32902caa1f4368181b49f012a4dbcb3
Gerrit-Change-Number: 18062
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
[Impala-ASF-CR] IMPALA-10764: hide /logs link in webui if --logtostderr=true
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18062 )
Change subject: IMPALA-10764: hide /logs link in webui if --logtostderr=true
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/18062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65234213f32902caa1f4368181b49f012a4dbcb3
Gerrit-Change-Number: 18062
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Dec 2021 01:32:31 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10764: hide /logs link in webui if --logtostderr=true
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18062 )
Change subject: IMPALA-10764: hide /logs link in webui if --logtostderr=true
......................................................................
IMPALA-10764: hide /logs link in webui if --logtostderr=true
If you start an Impala daemon with the flags
"--logtostderr=true --redirect_stdout_stderr=false"
then log files are not created. After this the webui will display an
error if you click on the "/logs" link. Fix this by not adding
the "/logs" link in this case.
TESTING
- Added a new test that validates the navbar links in the webui.
- Ran exhaustive tests
Change-Id: I65234213f32902caa1f4368181b49f012a4dbcb3
Reviewed-on: http://gerrit.cloudera.org:8080/18062
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/default-path-handlers.cc
M tests/custom_cluster/test_web_pages.py
2 files changed, 71 insertions(+), 1 deletion(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/18062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I65234213f32902caa1f4368181b49f012a4dbcb3
Gerrit-Change-Number: 18062
Gerrit-PatchSet: 3
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-10764: hide /logs link in webui if --logtostderr=true
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18062 )
Change subject: IMPALA-10764: hide /logs link in webui if --logtostderr=true
......................................................................
Patch Set 2:
Failure in verification looks like IMPALA-10886, will retry
--
To view, visit http://gerrit.cloudera.org:8080/18062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65234213f32902caa1f4368181b49f012a4dbcb3
Gerrit-Change-Number: 18062
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Dec 2021 16:23:14 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10764: hide /logs link in webui if --logtostderr=true
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18062 )
Change subject: IMPALA-10764: hide /logs link in webui if --logtostderr=true
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/9861/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65234213f32902caa1f4368181b49f012a4dbcb3
Gerrit-Change-Number: 18062
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Dec 2021 17:46:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10764: hide /logs link in webui if --logtostderr=true
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18062 )
Change subject: IMPALA-10764: hide /logs link in webui if --logtostderr=true
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65234213f32902caa1f4368181b49f012a4dbcb3
Gerrit-Change-Number: 18062
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Dec 2021 22:50:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10764: hide /logs link in webui if --logtostderr=true
Posted by "Andrew Sherman (Code Review)" <ge...@cloudera.org>.
Andrew Sherman has posted comments on this change. ( http://gerrit.cloudera.org:8080/18062 )
Change subject: IMPALA-10764: hide /logs link in webui if --logtostderr=true
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18062/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18062/1//COMMIT_MSG@10
PS1, Line 10: --redirect_stdout_stderr=false
> is this also required to ensure no logs are generated? if yes, should we ad
The default for redirect_stdout_stderr is true
and in a server (not a unit test) if redirect_stdout_stderr is true then FLAGS_alsologtostderr is reset to be false.
So I think the check on just FLAGS_alsologtostderr is sufficient.
--
To view, visit http://gerrit.cloudera.org:8080/18062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65234213f32902caa1f4368181b49f012a4dbcb3
Gerrit-Change-Number: 18062
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Dec 2021 19:42:04 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10764: hide /logs link in webui if --logtostderr=true
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18062 )
Change subject: IMPALA-10764: hide /logs link in webui if --logtostderr=true
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18062/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18062/1//COMMIT_MSG@10
PS1, Line 10: --redirect_stdout_stderr=false
> The default for redirect_stdout_stderr is true
got it, thanks for the explanation
--
To view, visit http://gerrit.cloudera.org:8080/18062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65234213f32902caa1f4368181b49f012a4dbcb3
Gerrit-Change-Number: 18062
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Dec 2021 01:01:15 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-10764: hide /logs link in webui if --logtostderr=true
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18062 )
Change subject: IMPALA-10764: hide /logs link in webui if --logtostderr=true
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7687/
--
To view, visit http://gerrit.cloudera.org:8080/18062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65234213f32902caa1f4368181b49f012a4dbcb3
Gerrit-Change-Number: 18062
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Dec 2021 07:53:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10764: hide /logs link in webui if --logtostderr=true
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18062 )
Change subject: IMPALA-10764: hide /logs link in webui if --logtostderr=true
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7687/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65234213f32902caa1f4368181b49f012a4dbcb3
Gerrit-Change-Number: 18062
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Dec 2021 01:32:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10764: hide /logs link in webui if --logtostderr=true
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18062 )
Change subject: IMPALA-10764: hide /logs link in webui if --logtostderr=true
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7688/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/18062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65234213f32902caa1f4368181b49f012a4dbcb3
Gerrit-Change-Number: 18062
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 02 Dec 2021 16:25:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10764: hide /logs link in webui if --logtostderr=true
Posted by "Bikramjeet Vig (Code Review)" <ge...@cloudera.org>.
Bikramjeet Vig has posted comments on this change. ( http://gerrit.cloudera.org:8080/18062 )
Change subject: IMPALA-10764: hide /logs link in webui if --logtostderr=true
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/18062/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/18062/1//COMMIT_MSG@10
PS1, Line 10: --redirect_stdout_stderr=false
is this also required to ensure no logs are generated? if yes, should we add a check on it too while removing the page?
--
To view, visit http://gerrit.cloudera.org:8080/18062
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I65234213f32902caa1f4368181b49f012a4dbcb3
Gerrit-Change-Number: 18062
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Sherman <as...@cloudera.com>
Gerrit-Reviewer: Bikramjeet Vig <bi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 01 Dec 2021 18:29:34 +0000
Gerrit-HasComments: Yes