You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by ul...@apache.org on 2021/07/21 04:19:27 UTC

[incubator-kyuubi] branch master updated: [KYUUBI #842] Fix meet rat check error when build kyuubi project

This is an automated email from the ASF dual-hosted git repository.

ulyssesyou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-kyuubi.git


The following commit(s) were added to refs/heads/master by this push:
     new bf0042c  [KYUUBI #842] Fix meet rat check error when build kyuubi project
bf0042c is described below

commit bf0042cbff2c2b70622d5be20784b00fdf8480e0
Author: timothy65535 <ti...@163.com>
AuthorDate: Wed Jul 21 12:19:17 2021 +0800

    [KYUUBI #842] Fix meet rat check error when build kyuubi project
    
    Fixes #842
    
    <!--
    Thanks for sending a pull request!
    
    Here are some tips for you:
      1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
      2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
      3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
    -->
    
    ### _Why are the changes needed?_
    <!--
    Please clarify why the changes are needed. For instance,
      1. If you add a feature, you can talk about the use case of it.
      2. If you fix a bug, you can clarify why it is a bug.
    -->
    
    ### 1. Describe the bug
    
    Meet rat check error when build kyuubi project
    ```
    [ERROR] Failed to execute goal org.apache.rat:apache-rat-plugin:0.13:check (default-cli) on project kyuubi: Too many files with unapproved license: 75 See RAT report in: /work/projects/opensource/kyuubi/target/rat.txt -> [Help 1]
    [ERROR]
    [ERROR] To see the full stack trace of the errors, re-run Maven with the -e switch.
    [ERROR] Re-run Maven using the -X switch to enable full debug logging.
    [ERROR]
    [ERROR] For more information about the errors and possible solutions, please read the following articles:
    [ERROR] [Help 1] http://cwiki.apache.org/confluence/display/MAVEN/MojoFailureException
    ```
    
    ### 2. Steps to reproduce
    
    1. Build kyuubi project
    ```
    ./build/dist --tgz --spark-provided -Pkyuubi-extension-spark_3.1
    ```
    2. Untar dist package and check some jars
    3. Build kyuubi again
    
    ### _How was this patch tested?_
    - [X] Add some test cases that check the changes thoroughly including negative and positive cases if possible
    
    ```
    mvn org.apache.rat:apache-rat-plugin:0.13:check
    ```
    
    - [ ] Add screenshots for manual tests if appropriate
    
    - [x] [Run test](https://kyuubi.readthedocs.io/en/latest/tools/testing.html#running-tests) locally before make a pull request
    
    ![image](https://user-images.githubusercontent.com/86483005/126352583-324bd9c2-8ce7-449e-bec6-00cb91823dfe.png)
    
    ```
    74 Unknown Licenses
    
    *****************************************************
    
    Files with unapproved licenses:
    
      kyuubi-1.3.0-SNAPSHOT-bin-spark-3.1-hadoop3.2/externals/spark-3.1.2-bin-hadoop3.2/data/mllib/ridge-data/lpsa.data
      kyuubi-1.3.0-SNAPSHOT-bin-spark-3.1-hadoop3.2/externals/spark-3.1.2-bin-hadoop3.2/data/mllib/als/test.data
      kyuubi-1.3.0-SNAPSHOT-bin-spark-3.1-hadoop3.2/externals/spark-3.1.2-bin-
      kyuubi-1.3.0-SNAPSHOT-bin-spark-3.1-hadoop3.2/externals/spark-3.1.2-bin-hadoop3.2/R/lib/SparkR/doc/sparkr-vignettes.R
      kyuubi-1.3.0-SNAPSHOT-bin-spark-3.1-hadoop3.2/externals/spark-3.1.2-bin-hadoop3.2/R/lib/SparkR/doc/index.html
      kyuubi-1.3.0-SNAPSHOT-bin-spark-3.1-hadoop3.2/externals/spark-3.1.2-bin-hadoop3.2/R/lib/SparkR/R/SparkR
      kyuubi-1.3.0-SNAPSHOT-bin-spark-3.1-hadoop3.2/RELEASE
      kyuubi-1.3.0-SNAPSHOT-bin-without-spark/RELEASE
    
    *****************************************************
    
    ```
    
    Closes #843 from timothy65535/ky-842.
    
    Closes #842
    
    a236167d [timothy65535] improve rat exclude list
    a7bc4fb0 [timothy65535] [KYUUBI #842] Fix meet rat check error when build kyuubi project
    
    Authored-by: timothy65535 <ti...@163.com>
    Signed-off-by: ulysses-you <ul...@gmail.com>
---
 pom.xml | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/pom.xml b/pom.xml
index d82b1e9..7df74c8 100644
--- a/pom.xml
+++ b/pom.xml
@@ -1371,6 +1371,8 @@
                             <exclude>build/scala-*/**</exclude>
                             <exclude>**/**/operation_logs/**/**</exclude>
                             <exclude>**/*.output.schema</exclude>
+                            <exclude>**/kyuubi-*-bin-without-spark/**</exclude>
+                            <exclude>**/kyuubi-*-bin-spark-*/**</exclude>
                         </excludes>
                     </configuration>
                 </plugin>