Author: robbie
Date: Fri Oct 1 11:03:35 2010
New Revision: 1003479
URL: http://svn.apache.org/viewvc?rev=1003479&view=rev
Log:
QPID-2857: Fix issue identified by running FindBugs across the codebase. Close reader when it is no longer required
Modified:
qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/util/FileUtils.java
Modified: qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/util/FileUtils.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/util/FileUtils.java?rev=1003479&r1=1003478&r2=1003479&view=diff
==============================================================================
--- qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/util/FileUtils.java (original)
+++ qpid/trunk/qpid/java/common/src/main/java/org/apache/qpid/util/FileUtils.java Fri Oct 1 11:03:35 2010
@@ -374,14 +374,21 @@ public class FileUtils
List<String> results = new LinkedList<String>();
BufferedReader reader = new BufferedReader(new FileReader(file));
- while (reader.ready())
+ try
{
- String line = reader.readLine();
- if (line.contains(search))
+ while (reader.ready())
{
- results.add(line);
+ String line = reader.readLine();
+ if (line.contains(search))
+ {
+ results.add(line);
+ }
}
}
+ finally
+ {
+ reader.close();
+ }
return results;
}
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org