You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jedcunningham (via GitHub)" <gi...@apache.org> on 2023/03/08 23:27:08 UTC
[GitHub] [airflow] jedcunningham commented on a diff in pull request #29978: Sync v2-5-stable with v2-5-test to release 2.5.2
jedcunningham commented on code in PR #29978:
URL: https://github.com/apache/airflow/pull/29978#discussion_r1130194491
##########
RELEASE_NOTES.rst:
##########
@@ -21,6 +21,113 @@
.. towncrier release notes start
+Airflow 2.5.2 (2023-03-13)
+--------------------------
+
+Significant Changes
+^^^^^^^^^^^^^^^^^^^
+
+The date-time fields passed as API parameters or Params should be RFC3339-compliant (#29395)
+"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""
+
+ In case of API calls, it was possible that "+" passed as part of the date-time fields were not URL-encoded, and
+ such date-time fields could pass validation. Such date-time parameters should now be URL-encoded (as ``%2B``).
+
+ In case of parameters, we still allow IS8601-compliant date-time (so for example it is possible that
+ ' ' was used instead of ``T`` separating date from time and no timezone was specified) but we raise
+ deprecation warning. (#29395)
Review Comment:
```suggestion
In case of API calls, it was possible that "+" passed as part of the date-time fields were not URL-encoded, and
such date-time fields could pass validation. Such date-time parameters should now be URL-encoded (as ``%2B``).
In case of parameters, we still allow IS8601-compliant date-time (so for example it is possible that
' ' was used instead of ``T`` separating date from time and no timezone was specified) but we raise
deprecation warning.
```
Don't need these indented (not sure why recent releases are, PR incoming), nor the PR number duplicated.
##########
RELEASE_NOTES.rst:
##########
@@ -21,6 +21,113 @@
.. towncrier release notes start
+Airflow 2.5.2 (2023-03-13)
+--------------------------
+
+Significant Changes
+^^^^^^^^^^^^^^^^^^^
+
+The date-time fields passed as API parameters or Params should be RFC3339-compliant (#29395)
+"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""
+
+ In case of API calls, it was possible that "+" passed as part of the date-time fields were not URL-encoded, and
+ such date-time fields could pass validation. Such date-time parameters should now be URL-encoded (as ``%2B``).
+
+ In case of parameters, we still allow IS8601-compliant date-time (so for example it is possible that
+ ' ' was used instead of ``T`` separating date from time and no timezone was specified) but we raise
+ deprecation warning. (#29395)
+
+Default for ``[webserver] expose_hostname`` changed to ``False`` (#29547)
+"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""
+
+ The default for ``[webserver] expose_hostname`` has been set to ``False``, instead of ``True``. This means administrators must opt-in to expose webserver hostnames to end users. (#29547)
Review Comment:
```suggestion
The default for ``[webserver] expose_hostname`` has been set to ``False``, instead of ``True``. This means administrators must opt-in to expose webserver hostnames to end users.
```
##########
RELEASE_NOTES.rst:
##########
@@ -21,6 +21,113 @@
.. towncrier release notes start
+Airflow 2.5.2 (2023-03-13)
+--------------------------
+
+Significant Changes
+^^^^^^^^^^^^^^^^^^^
+
+The date-time fields passed as API parameters or Params should be RFC3339-compliant (#29395)
+"""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""
Review Comment:
```suggestion
""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""""
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org