[GitHub] [iceberg] rdblue commented on a change in pull request #2858: Core: Support multiple specs in OutputFileFactory

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #2858:
URL: https://github.com/apache/iceberg/pull/2858#discussion_r676189525



##########
File path: core/src/main/java/org/apache/iceberg/io/OutputFileFactory.java
##########
@@ -95,25 +100,71 @@ public OutputFileFactory(PartitionSpec spec, FileFormat format, LocationProvider
     this.operationId = operationId;
   }
 
+  public static Builder builderFor(Table table, FileFormat format, int partitionId, long taskId) {

Review comment:
       What about removing format and defaulting that using the table property? Then if an engine wants to override it can, but otherwise it is automatic.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org