You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2020/08/13 04:05:24 UTC

[GitHub] [skywalking] codecov[bot] edited a comment on pull request #5306: Remove duplicate settings telemetry related context id in nacos.

codecov[bot] edited a comment on pull request #5306:
URL: https://github.com/apache/skywalking/pull/5306#issuecomment-673218952


   # [Codecov](https://codecov.io/gh/apache/skywalking/pull/5306?src=pr&el=h1) Report
   > Merging [#5306](https://codecov.io/gh/apache/skywalking/pull/5306?src=pr&el=desc) into [master](https://codecov.io/gh/apache/skywalking/commit/a7e77832a96db3a8dc5db1c9aafd4db6234932c5&el=desc) will **increase** coverage by `53.34%`.
   > The diff coverage is `n/a`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/skywalking/pull/5306/graphs/tree.svg?width=650&height=150&src=pr&token=qrILxY5yA8)](https://codecov.io/gh/apache/skywalking/pull/5306?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5306       +/-   ##
   =============================================
   + Coverage      0.00%   53.34%   +53.34%     
   - Complexity        0     3199     +3199     
   =============================================
     Files           164     1491     +1327     
     Lines          4027    32264    +28237     
     Branches        470     3556     +3086     
   =============================================
   + Hits              0    17211    +17211     
   - Misses         4027    14236    +10209     
   - Partials          0      817      +817     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/skywalking/pull/5306?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [.../server/cluster/plugin/nacos/NacosCoordinator.java](https://codecov.io/gh/apache/skywalking/pull/5306/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY2x1c3Rlci1wbHVnaW4vY2x1c3Rlci1uYWNvcy1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9jbHVzdGVyL3BsdWdpbi9uYWNvcy9OYWNvc0Nvb3JkaW5hdG9yLmphdmE=) | `67.85% <ø> (ø)` | `0.00 <0.00> (?)` | |
   | [...t/core/plugin/bytebuddy/ArgumentTypeNameMatch.java](https://codecov.io/gh/apache/skywalking/pull/5306/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9Bcmd1bWVudFR5cGVOYW1lTWF0Y2guamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...lugin/bytebuddy/CacheableTransformerDecorator.java](https://codecov.io/gh/apache/skywalking/pull/5306/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLWFnZW50LWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL2FnZW50L2NvcmUvcGx1Z2luL2J5dGVidWRkeS9DYWNoZWFibGVUcmFuc2Zvcm1lckRlY29yYXRvci5qYXZh) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (ø%)` | |
   | [...figuration/apollo/ApolloConfigurationProvider.java](https://codecov.io/gh/apache/skywalking/pull/5306/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29uZmlndXJhdGlvbi9jb25maWd1cmF0aW9uLWFwb2xsby9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvbmZpZ3VyYXRpb24vYXBvbGxvL0Fwb2xsb0NvbmZpZ3VyYXRpb25Qcm92aWRlci5qYXZh) | `22.22% <0.00%> (ø)` | `2.00% <0.00%> (?%)` | |
   | [...ructorWithInetSocketAddressListArgInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5306/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4veG1lbWNhY2hlZC0yLngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4veG1lbWNhY2hlZC92Mi9YTWVtY2FjaGVkQ29uc3RydWN0b3JXaXRoSW5ldFNvY2tldEFkZHJlc3NMaXN0QXJnSW50ZXJjZXB0b3IuamF2YQ==) | `91.66% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | [...core/analysis/manual/instance/InstanceTraffic.java](https://codecov.io/gh/apache/skywalking/pull/5306/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9vYXAvc2VydmVyL2NvcmUvYW5hbHlzaXMvbWFudWFsL2luc3RhbmNlL0luc3RhbmNlVHJhZmZpYy5qYXZh) | `56.00% <0.00%> (ø)` | `7.00% <0.00%> (?%)` | |
   | [...ControllerForLowVersionConstructorInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5306/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vc3ByaW5nLXBsdWdpbnMvbXZjLWFubm90YXRpb24tNC54LXBsdWdpbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2t5d2Fsa2luZy9hcG0vcGx1Z2luL3NwcmluZy9tdmMvdjQvQ29udHJvbGxlckZvckxvd1ZlcnNpb25Db25zdHJ1Y3RvckludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | [...teway/v21x/HttpClientFinalizerSendInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5306/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvb3B0aW9uYWwtcGx1Z2lucy9vcHRpb25hbC1zcHJpbmctcGx1Z2lucy9vcHRpb25hbC1zcHJpbmctY2xvdWQvZ2F0ZXdheS0yLjEueC1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvYXBtL3BsdWdpbi9zcHJpbmcvY2xvdWQvZ2F0ZXdheS92MjF4L0h0dHBDbGllbnRGaW5hbGl6ZXJTZW5kSW50ZXJjZXB0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | [...oap/server/receiver/zipkin/handler/SpanEncode.java](https://codecov.io/gh/apache/skywalking/pull/5306/diff?src=pr&el=tree#diff-b2FwLXNlcnZlci9zZXJ2ZXItcmVjZWl2ZXItcGx1Z2luL3ppcGtpbi1yZWNlaXZlci1wbHVnaW4vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NreXdhbGtpbmcvb2FwL3NlcnZlci9yZWNlaXZlci96aXBraW4vaGFuZGxlci9TcGFuRW5jb2RlLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | [...e/v5/RedisClusterClientConstructorInterceptor.java](https://codecov.io/gh/apache/skywalking/pull/5306/diff?src=pr&el=tree#diff-YXBtLXNuaWZmZXIvYXBtLXNkay1wbHVnaW4vbGV0dHVjZS01LngtcGx1Z2luL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9za3l3YWxraW5nL2FwbS9wbHVnaW4vbGV0dHVjZS92NS9SZWRpc0NsdXN0ZXJDbGllbnRDb25zdHJ1Y3RvckludGVyY2VwdG9yLmphdmE=) | `0.00% <0.00%> (ø)` | `0.00% <0.00%> (?%)` | |
   | ... and [1464 more](https://codecov.io/gh/apache/skywalking/pull/5306/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/skywalking/pull/5306?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/skywalking/pull/5306?src=pr&el=footer). Last update [a7e7783...03501e7](https://codecov.io/gh/apache/skywalking/pull/5306?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org