You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "linghengqian (via GitHub)" <gi...@apache.org> on 2026/10/27 07:13:16 UTC

[PR] Registry Center: Skip revoking already expired leases when closing EtcdRegistryCenter [shardingsphere-elasticjob]

linghengqian opened a new pull request, #2560:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2560

   For #2436 .
   
   Changes proposed in this pull request:
   - Registry Center: Skip revoking already expired leases when closing EtcdRegistryCenter.
     - Without this PR, shutting down EtcdRegistryCenter logs a misleading warning with a full stack trace for every lease that has already expired on the etcd server. Ephemeral keys are bound to a 30s-TTL lease, and close() revokes each tracked lease ID; if a lease expired before shutdown, the server answers revoke with gRPC NOT_FOUND ("etcdserver: requested lease not found"), which surfaces as an ExecutionException from Future.get(). The old catch-all handler logged all revoke failures as Failed to revoke lease at warn level, even though an expired lease is already the desired end state and revoking it is a no-op. The fix walks the cause chain for StatusRuntimeException with code NOT_FOUND and downgrades that case to a debug log, so only genuine revoke failures still warn.
   - Split off from https://github.com/apache/shardingsphere-elasticjob/pull/2548 .
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Registry Center: Skip revoking already expired leases when closing EtcdRegistryCenter [shardingsphere-elasticjob]

Posted by "RaigorJiang (via GitHub)" <gi...@apache.org>.
RaigorJiang merged PR #2560:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/2560


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org