You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2016/12/02 21:57:59 UTC

Re: Review Request 54036: Fixed WebUI error on Firefox 45.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54036/#review157836
-----------------------------------------------------------


Ship it!




Ship It!

- Benjamin Mahler


On Nov. 23, 2016, 4:53 p.m., haosdent huang wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54036/
> -----------------------------------------------------------
> 
> (Updated Nov. 23, 2016, 4:53 p.m.)
> 
> 
> Review request for mesos, Benjamin Mahler and Vinod Kone.
> 
> 
> Bugs: MESOS-6624
>     https://issues.apache.org/jira/browse/MESOS-6624
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> Adjust the order of function `matchTask` to fix the WebUI error on
> Firefox 45.
> 
> 
> Diffs
> -----
> 
>   src/webui/master/static/js/controllers.js dd0cc810748a9bd378d9c6b15e9fe89b7c0f11d9 
> 
> Diff: https://reviews.apache.org/r/54036/diff/
> 
> 
> Testing
> -------
> 
> # Test with Firefox 45 on MacOS (https://ftp.mozilla.org/pub/firefox/releases/45.0.1/mac/en-US/)
> Without this patch, the WebUI would show error in the console.
> 
> 
> Thanks,
> 
> haosdent huang
> 
>