You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2015/12/21 12:10:30 UTC
[GitHub] flink pull request: [FLINK-2622] [streaming] Align Scala streaming...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/1473
[FLINK-2622] [streaming] Align Scala streaming writeAsCsv API call with Java API
Allows the Scala API to call `writeAsCsv` with the same parameters as the Java API does.
This PR is a take over of PR #1098, which does not show activity anymore.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink FLINK-2622
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1473.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1473
----
commit c936e8bfa8a7fff12028606ff32b3054e63ee7a8
Author: Till Rohrmann <tr...@apache.org>
Date: 2015-09-18T07:31:29Z
[FLINK-2622] [streaming] Align Scala streaming writeAsCsv API call with Java API
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2622] [streaming] Align Scala streaming...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/1473
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2622] [streaming] Align Scala streaming...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on a diff in the pull request:
https://github.com/apache/flink/pull/1473#discussion_r48154545
--- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java ---
@@ -937,26 +941,40 @@ public ExecutionConfig getExecutionConfig() {
* NO_OVERWRITE and OVERWRITE.
* @param millis
* the file update frequency
- *
+ * @param rowDelimiter
+ * the delimiter for two rows
+ * @param fieldDelimiter
+ * the delimiter for two fields
+ *
* @return the closed DataStream
*/
@SuppressWarnings("unchecked")
- public <X extends Tuple> DataStreamSink<T> writeAsCsv(String path, WriteMode writeMode,
- long millis) {
- Preconditions.checkArgument(getType().isTupleType(),
- "The writeAsCsv() method can only be used on data sets of tuples.");
- CsvOutputFormat<X> of = new CsvOutputFormat<X>(new Path(path),
- CsvOutputFormat.DEFAULT_LINE_DELIMITER, CsvOutputFormat.DEFAULT_FIELD_DELIMITER);
+ public <X extends Tuple> DataStreamSink<T> writeAsCsv(
+ String path,
+ WriteMode writeMode,
+ long millis,
+ String rowDelimiter,
+ String fieldDelimiter) {
+ Preconditions.checkArgument(
+ getType().isTupleType(),
+ "The writeAsCsv() method can only be used on data sets of tuples.");
--- End diff --
"data sets" should be "data streams"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2622] [streaming] Align Scala streaming...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/1473#discussion_r48155123
--- Diff: flink-streaming-java/src/main/java/org/apache/flink/streaming/api/datastream/DataStream.java ---
@@ -937,26 +941,40 @@ public ExecutionConfig getExecutionConfig() {
* NO_OVERWRITE and OVERWRITE.
* @param millis
* the file update frequency
- *
+ * @param rowDelimiter
+ * the delimiter for two rows
+ * @param fieldDelimiter
+ * the delimiter for two fields
+ *
* @return the closed DataStream
*/
@SuppressWarnings("unchecked")
- public <X extends Tuple> DataStreamSink<T> writeAsCsv(String path, WriteMode writeMode,
- long millis) {
- Preconditions.checkArgument(getType().isTupleType(),
- "The writeAsCsv() method can only be used on data sets of tuples.");
- CsvOutputFormat<X> of = new CsvOutputFormat<X>(new Path(path),
- CsvOutputFormat.DEFAULT_LINE_DELIMITER, CsvOutputFormat.DEFAULT_FIELD_DELIMITER);
+ public <X extends Tuple> DataStreamSink<T> writeAsCsv(
+ String path,
+ WriteMode writeMode,
+ long millis,
+ String rowDelimiter,
+ String fieldDelimiter) {
+ Preconditions.checkArgument(
+ getType().isTupleType(),
+ "The writeAsCsv() method can only be used on data sets of tuples.");
--- End diff --
Good catch. Will change it. Thx.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request: [FLINK-2622] [streaming] Align Scala streaming...
Posted by fhueske <gi...@git.apache.org>.
Github user fhueske commented on the pull request:
https://github.com/apache/flink/pull/1473#issuecomment-166329040
LGTM. Will merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---