You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by jkbradley <gi...@git.apache.org> on 2014/12/31 09:35:52 UTC
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
GitHub user jkbradley opened a pull request:
https://github.com/apache/spark/pull/3856
[SPARK-5032] [graphx] Remove GraphX MIMA exclude for 1.3
Since GraphX is no longer alpha as of 1.2, MimaExcludes should not exclude GraphX for 1.3
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkbradley/spark graphx-mima
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/3856.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3856
----
commit a3fea4282f9f96d6b5bb5d378ba6198160d84c31
Author: Joseph K. Bradley <jo...@databricks.com>
Date: 2014-12-31T08:30:51Z
removed graphx mima exclude for 1.3
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68815517
[Test build #25074 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25074/consoleFull) for PR 3856 at commit [`802e252`](https://github.com/apache/spark/commit/802e2529d6a22a548e623ca9ea2c0d34fb89e2b3).
* This patch **fails MiMa tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68819654
Okay looks like that was the issue! Let's just put this clean-up in run-tests. It looks like we already do some stuff there:
https://github.com/apache/spark/blob/master/dev/run-tests#L25
I'd just do this:
```
# Clean up work directory and caches
rm -rf ./work
rm -rf ~/.ivy2/local/org.apache.spark
rm -rf ~/.ivy2/cache/org.apache.spark
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/3856
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68462221
[Test build #24965 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24965/consoleFull) for PR 3856 at commit [`30f8bb4`](https://github.com/apache/spark/commit/30f8bb4cbe472a536c9506a7365e76f736adcb33).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-69245017
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68818808
[Test build #25079 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25079/consoleFull) for PR 3856 at commit [`527ccd9`](https://github.com/apache/spark/commit/527ccd91417df528deedb724aa18848f11911107).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68826220
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25088/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68430068
[Test build #24953 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24953/consoleFull) for PR 3856 at commit [`a3fea42`](https://github.com/apache/spark/commit/a3fea4282f9f96d6b5bb5d378ba6198160d84c31).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68815522
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25074/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68467221
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24965/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68464735
@pwendell Check out the MIMA failures before the excludes:
```
[error] * abstract method unpersist(Boolean)org.apache.spark.graphx.Graph in class org.apache.spark.graphx.Graph does not have a correspondent in old version
[error] filter with: ProblemFilters.exclude[MissingMethodProblem]("org.apache.spark.graphx.Graph.unpersist")
[error] * abstract method checkpoint()Unit in class org.apache.spark.graphx.Graph does not have a correspondent in old version
[error] filter with: ProblemFilters.exclude[MissingMethodProblem]("org.apache.spark.graphx.Graph.checkpoint")
[error] * method fromEdges(org.apache.spark.rdd.RDD,scala.reflect.ClassTag,scala.reflect.ClassTag)org.apache.spark.graphx.EdgeRDD in object org.apache.spark.graphx.EdgeRDD has now a different result type; was: org.apache.spark.graphx.EdgeRDD, is now: org.apache.spark.graphx.impl.EdgeRDDImpl
[error] filter with: ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.graphx.EdgeRDD.fromEdges")
[error] * abstract method filter(scala.Function1,scala.Function2)org.apache.spark.graphx.EdgeRDD in class org.apache.spark.graphx.EdgeRDD does not have a correspondent in new version
[error] filter with: ProblemFilters.exclude[MissingMethodProblem]("org.apache.spark.graphx.EdgeRDD.filter")
[error] * method filter(scala.Function1,scala.Function2)org.apache.spark.graphx.EdgeRDD in class org.apache.spark.graphx.impl.EdgeRDDImpl has now a different result type; was: org.apache.spark.graphx.EdgeRDD, is now: org.apache.spark.graphx.impl.EdgeRDDImpl
[error] filter with: ProblemFilters.exclude[IncompatibleResultTypeProblem]("org.apache.spark.graphx.impl.EdgeRDDImpl.filter")
```
Were the version tags not centered at the right commits?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68433311
[Test build #24953 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24953/consoleFull) for PR 3856 at commit [`a3fea42`](https://github.com/apache/spark/commit/a3fea4282f9f96d6b5bb5d378ba6198160d84c31).
* This patch **fails MiMa tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68822597
[Test build #25088 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25088/consoleFull) for PR 3856 at commit [`1eea2f6`](https://github.com/apache/spark/commit/1eea2f643d55ef72783c26b5bc4fdac8ec4af23b).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68813591
[Test build #25079 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25079/consoleFull) for PR 3856 at commit [`527ccd9`](https://github.com/apache/spark/commit/527ccd91417df528deedb724aa18848f11911107).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68433315
Test FAILed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/24953/
Test FAILed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68467217
[Test build #24965 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/24965/consoleFull) for PR 3856 at commit [`30f8bb4`](https://github.com/apache/spark/commit/30f8bb4cbe472a536c9506a7365e76f736adcb33).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68463177
Hey @jkbradley - are you sure those excludes are necessary? All of the patches you mentioned are in Spark 1.2 already.... excludes should only be relevant to things that changed between 1.2 and the master branch. Ideally we haven't made any breaking changes since the 1.2 release.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68822521
@pwendell OK, I moved the rm's. Thanks for your help! (This should be correct...but running the test may not actually test correctness since the caches have already been cleared.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68818812
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/25079/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68809733
[Test build #25074 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25074/consoleFull) for PR 3856 at commit [`802e252`](https://github.com/apache/spark/commit/802e2529d6a22a548e623ca9ea2c0d34fb89e2b3).
* This patch merges cleanly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68826217
[Test build #25088 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/25088/consoleFull) for PR 3856 at commit [`1eea2f6`](https://github.com/apache/spark/commit/1eea2f643d55ef72783c26b5bc4fdac8ec4af23b).
* This patch **passes all tests**.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by pwendell <gi...@git.apache.org>.
Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-69479694
Okay great - I'm merging this.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: [SPARK-5032] [graphx] Remove GraphX MIMA exclu...
Posted by jkbradley <gi...@git.apache.org>.
Github user jkbradley commented on the pull request:
https://github.com/apache/spark/pull/3856#issuecomment-68430096
This is not fixed yet; I need to include some Mima excludes for GraphX, it seems. I'll update this within a day once I track down the JIRAs to associate with the excludes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org