You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by HyukjinKwon <gi...@git.apache.org> on 2017/02/06 13:26:20 UTC

[GitHub] spark issue #16680: [SPARK-16101][SQL] Refactoring CSV schema inference path...

Github user HyukjinKwon commented on the issue:

    https://github.com/apache/spark/pull/16680
  
    @cloud-fan, I just mainly resembled ones in JSON datasource and I am pretty sure you knew this when you added some comments. But let me just rebase this as is for now just in case maybe you are okay with them above and missed my reasons. 
    
    I know it is not always true to follow existing implementation but maybe we could rename them together if the other one does not look appropriate. (I am fine with either way but just want to be sure that you know I had some reasons).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org