You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@systemml.apache.org by GitBox <gi...@apache.org> on 2020/04/21 21:16:38 UTC
[GitHub] [systemml] sebwrede opened a new pull request #895: Privacy Metadata initial
sebwrede opened a new pull request #895:
URL: https://github.com/apache/systemml/pull/895
This pull request adds privacy constraints as metadata. The privacy constraints are propagated from input to result of matrix multiplications. The privacy constraints currently only contain a simple boolean, which represents whether the data may be shared or not, but more complex constraints will later be added to the PrivacyConstraint class.
This pull request replaces the [Privacy Metadata pull request](https://github.com/apache/systemml/pull/894).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] sebwrede commented on issue #895: Privacy Metadata initial
Posted by GitBox <gi...@apache.org>.
sebwrede commented on issue #895:
URL: https://github.com/apache/systemml/pull/895#issuecomment-618388313
I will rebase this branch to resolve the conflicts. Please wait with any edits.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] sebwrede commented on issue #895: Privacy Metadata initial
Posted by GitBox <gi...@apache.org>.
sebwrede commented on issue #895:
URL: https://github.com/apache/systemml/pull/895#issuecomment-618410337
The rebase is done. The checks are failing because [Github's servers are having problems](https://www.githubstatus.com/).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] mboehm7 commented on pull request #895: Privacy Metadata initial
Posted by GitBox <gi...@apache.org>.
mboehm7 commented on pull request #895:
URL: https://github.com/apache/systemml/pull/895#issuecomment-619192271
LGTM - thanks for the initial integration @sebwrede. During the merge I made only some minor formatting fixes (tabs over spaces, verbosity) and slightly changed the hop/lop metadata handover.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] j143 commented on a change in pull request #895: Privacy Metadata initial
Posted by GitBox <gi...@apache.org>.
j143 commented on a change in pull request #895:
URL: https://github.com/apache/systemml/pull/895#discussion_r412642960
##########
File path: src/main/java/org/tugraz/sysds/parser/DataExpression.java
##########
@@ -109,31 +113,70 @@
public static final String DELIM_SPARSE = "sparse"; // applicable only for write
- public static final String[] RAND_VALID_PARAM_NAMES =
- {RAND_ROWS, RAND_COLS, RAND_DIMS, RAND_MIN, RAND_MAX, RAND_SPARSITY, RAND_SEED, RAND_PDF, RAND_LAMBDA};
+ public static final Set<String> RAND_VALID_PARAM_NAMES =
Review comment:
If this is a formatting change, the progress might be slowed. The best method would be to make any formatting changes in a different PR. or adhering to the existing formatting.
##########
File path: src/main/java/org/tugraz/sysds/runtime/instructions/Instruction.java
##########
@@ -27,6 +27,7 @@
import org.tugraz.sysds.lops.Lop;
import org.tugraz.sysds.parser.DataIdentifier;
Review comment:
Can the class names be updated to reflect `org.apache`, instead of `org.tugraz` to trigger integration tests.
##########
File path: src/main/java/org/tugraz/sysds/runtime/privacy/PrivacyConstraint.java
##########
@@ -0,0 +1,42 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+package org.tugraz.sysds.runtime.privacy;
+
+/**
Review comment:
While the design is fresh in memory, shall we add the implementation related documentation or design in this file.
Perhaps something like [this](https://github.com/apache/systemml/blob/cf74661016928e3413d693f939a67964f3256b19/src/main/java/org/apache/sysds/runtime/instructions/gpu/context/GPUMemoryManager.java#L62)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [systemml] sebwrede commented on a change in pull request #895: Privacy Metadata initial
Posted by GitBox <gi...@apache.org>.
sebwrede commented on a change in pull request #895:
URL: https://github.com/apache/systemml/pull/895#discussion_r412793957
##########
File path: src/main/java/org/tugraz/sysds/parser/DataExpression.java
##########
@@ -109,31 +113,70 @@
public static final String DELIM_SPARSE = "sparse"; // applicable only for write
- public static final String[] RAND_VALID_PARAM_NAMES =
- {RAND_ROWS, RAND_COLS, RAND_DIMS, RAND_MIN, RAND_MAX, RAND_SPARSITY, RAND_SEED, RAND_PDF, RAND_LAMBDA};
+ public static final Set<String> RAND_VALID_PARAM_NAMES =
Review comment:
I needed to add privacy to the parameter array and then I noticed inconsistencies in how parameters are checked using the arrays, so I decided to change it. It could easily be a separate PR and I will try to be better at making this kind of update in separate PRs in the future.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org