You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/01 12:58:53 UTC
[GitHub] [shardingsphere-elasticjob] HombioChan opened a new pull request #1798: resolve issue#1746
HombioChan opened a new pull request #1798:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1798
Fixes #ISSUSE_1746.
Changes proposed in this pull request:
- FullHttpResponse use default buffer(unpooled heap buffer)
- relase httpRequest refcnt in HandlerParameterDecoder
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1798: fix issue#1746
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1798:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1798#issuecomment-753323461
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798?src=pr&el=h1) Report
> Merging [#1798](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798?src=pr&el=desc) (9229488) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/352af4203844e7446a9b1d9dd5e946e014aade3e?el=desc) (352af42) will **decrease** coverage by `0.06%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1798 +/- ##
============================================
- Coverage 85.89% 85.82% -0.07%
+ Complexity 113 112 -1
============================================
Files 274 274
Lines 5927 5928 +1
Branches 907 907
============================================
- Hits 5091 5088 -3
- Misses 507 511 +4
Partials 329 329
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../pipeline/ContextInitializationInboundHandler.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9waXBlbGluZS9Db250ZXh0SW5pdGlhbGl6YXRpb25JbmJvdW5kSGFuZGxlci5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...cjob/restful/pipeline/HandlerParameterDecoder.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9waXBlbGluZS9IYW5kbGVyUGFyYW1ldGVyRGVjb2Rlci5qYXZh) | `69.87% <100.00%> (+0.36%)` | `0.00 <0.00> (ø)` | |
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `77.77% <0.00%> (-4.77%)` | `0.00% <0.00%> (ø%)` | |
| [...e/shardingsphere/elasticjob/infra/env/IpUtils.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLWluZnJhLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9pbmZyYS9lbnYvSXBVdGlscy5qYXZh) | `60.00% <0.00%> (-4.62%)` | `0.00% <0.00%> (ø%)` | |
| [...sticjob/reg/zookeeper/ZookeeperRegistryCenter.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlZ2lzdHJ5LWNlbnRlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvZWxhc3RpY2pvYi9yZWcvem9va2VlcGVyL1pvb2tlZXBlclJlZ2lzdHJ5Q2VudGVyLmphdmE=) | `72.44% <0.00%> (-0.79%)` | `32.00% <0.00%> (-1.00%)` | |
| [...elasticjob/restful/pipeline/ExceptionHandling.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9waXBlbGluZS9FeGNlcHRpb25IYW5kbGluZy5qYXZh) | `95.12% <0.00%> (+7.31%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798?src=pr&el=footer). Last update [352af42...9229488](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io edited a comment on pull request #1798: fix issue#1746
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #1798:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1798#issuecomment-753323461
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798?src=pr&el=h1) Report
> Merging [#1798](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798?src=pr&el=desc) (9229488) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/352af4203844e7446a9b1d9dd5e946e014aade3e?el=desc) (352af42) will **increase** coverage by `0.05%`.
> The diff coverage is `100.00%`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1798 +/- ##
============================================
+ Coverage 85.89% 85.94% +0.05%
Complexity 113 113
============================================
Files 274 274
Lines 5927 5928 +1
Branches 907 907
============================================
+ Hits 5091 5095 +4
+ Misses 507 505 -2
+ Partials 329 328 -1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [.../pipeline/ContextInitializationInboundHandler.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9waXBlbGluZS9Db250ZXh0SW5pdGlhbGl6YXRpb25JbmJvdW5kSGFuZGxlci5qYXZh) | `100.00% <100.00%> (ø)` | `1.00 <0.00> (ø)` | |
| [...cjob/restful/pipeline/HandlerParameterDecoder.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9waXBlbGluZS9IYW5kbGVyUGFyYW1ldGVyRGVjb2Rlci5qYXZh) | `69.87% <100.00%> (+0.36%)` | `0.00 <0.00> (ø)` | |
| [...elasticjob/restful/pipeline/ExceptionHandling.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1pbmZyYS9lbGFzdGljam9iLXJlc3RmdWwvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2VsYXN0aWNqb2IvcmVzdGZ1bC9waXBlbGluZS9FeGNlcHRpb25IYW5kbGluZy5qYXZh) | `95.12% <0.00%> (+7.31%)` | `0.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798?src=pr&el=footer). Last update [352af42...9229488](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1798?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN closed pull request #1798: fix issue#1746
Posted by GitBox <gi...@apache.org>.
TeslaCN closed pull request #1798:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1798
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] TeslaCN commented on pull request #1798: fix issue#1746
Posted by GitBox <gi...@apache.org>.
TeslaCN commented on pull request #1798:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1798#issuecomment-753333376
https://github.com/apache/shardingsphere-elasticjob/pull/1798/checks#step:5:1033
The assertion failed but the testcase passed because assertion is on another thread. We need further consideration about this issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org