You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Jonathan Hurley <jh...@hortonworks.com> on 2014/06/30 21:50:24 UTC
Review Request 23174: Nagios failed to start on stack upgraded cluster
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23174/
-----------------------------------------------------------
Review request for Ambari, Nate Cole and Sumit Mohanty.
Bugs: AMBARI-6320
https://issues.apache.org/jira/browse/AMBARI-6320
Repository: ambari
Description
-------
Upgrade logic is wrong; the hdfs properties that are required for a 2.1 stack should not be a part of the Ambari 1.6.0 DML schema upgrade. Instead, they should be a part of the stack upgrade.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java c359afa
ambari-server/src/main/python/UpgradeHelper_HDP2.py 0c43850
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 59c73f2
Diff: https://reviews.apache.org/r/23174/diff/
Testing
-------
# verified hdfs-site.xml was updated with required properties and that Nagios started in my upgrade cluster
$ python UpgradeHelper_HDP2.py --hostname $HOSTNAME --user $USERNAME --password $PASSWORD --clustername $CLUSTERNAME update-configs
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:19.307s
[INFO] Finished at: Mon Jun 30 15:43:10 EDT 2014
[INFO] Final Memory: 21M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Jonathan Hurley
Re: Review Request 23174: Nagios failed to start on stack upgraded cluster
Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23174/#review47056
-----------------------------------------------------------
Ship it!
Ship It!
- Nate Cole
On June 30, 2014, 11 p.m., Jonathan Hurley wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23174/
> -----------------------------------------------------------
>
> (Updated June 30, 2014, 11 p.m.)
>
>
> Review request for Ambari, Nate Cole and Sumit Mohanty.
>
>
> Bugs: AMBARI-6320
> https://issues.apache.org/jira/browse/AMBARI-6320
>
>
> Repository: ambari
>
>
> Description
> -------
>
> Upgrade logic is wrong; the hdfs properties that are required for a 2.1 stack should not be a part of the Ambari 1.6.0 DML schema upgrade. Instead, they should be a part of the stack upgrade.
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java c359afa
> ambari-server/src/main/python/UpgradeHelper_HDP2.py 0c43850
> ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py cb3d5c1
> ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 59c73f2
>
> Diff: https://reviews.apache.org/r/23174/diff/
>
>
> Testing
> -------
>
> # verified hdfs-site.xml was updated with required properties and that Nagios started in my upgrade cluster
> $ python UpgradeHelper_HDP2.py --hostname $HOSTNAME --user $USERNAME --password $PASSWORD --clustername $CLUSTERNAME update-configs
>
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 13:19.307s
> [INFO] Finished at: Mon Jun 30 15:43:10 EDT 2014
> [INFO] Final Memory: 21M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Jonathan Hurley
>
>
Re: Review Request 23174: Nagios failed to start on stack upgraded cluster
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23174/
-----------------------------------------------------------
(Updated July 1, 2014, 2:20 p.m.)
Review request for Ambari, Nate Cole and Sumit Mohanty.
Bugs: AMBARI-6320
https://issues.apache.org/jira/browse/AMBARI-6320
Repository: ambari
Description
-------
Upgrade logic is wrong; the hdfs properties that are required for a 2.1 stack should not be a part of the Ambari 1.6.0 DML schema upgrade. Instead, they should be a part of the stack upgrade.
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java c359afa
ambari-server/src/main/python/UpgradeHelper_HDP2.py 0c43850
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py cb3d5c1
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 59c73f2
Diff: https://reviews.apache.org/r/23174/diff/
Testing
-------
# verified hdfs-site.xml was updated with required properties and that Nagios started in my upgrade cluster
$ python UpgradeHelper_HDP2.py --hostname $HOSTNAME --user $USERNAME --password $PASSWORD --clustername $CLUSTERNAME update-configs
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:19.307s
[INFO] Finished at: Mon Jun 30 15:43:10 EDT 2014
[INFO] Final Memory: 21M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Jonathan Hurley
Re: Review Request 23174: Nagios failed to start on stack upgraded cluster
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23174/
-----------------------------------------------------------
(Updated June 30, 2014, 11 p.m.)
Review request for Ambari, Nate Cole and Sumit Mohanty.
Changes
-------
Implementing suggested defaults to ensure that on a 2.0 -> 2.1 upgrade, these properties will not cause Nagios to fail on startup.
Bugs: AMBARI-6320
https://issues.apache.org/jira/browse/AMBARI-6320
Repository: ambari
Description
-------
Upgrade logic is wrong; the hdfs properties that are required for a 2.1 stack should not be a part of the Ambari 1.6.0 DML schema upgrade. Instead, they should be a part of the stack upgrade.
Diffs (updated)
-----
ambari-server/src/main/java/org/apache/ambari/server/upgrade/UpgradeCatalog160.java c359afa
ambari-server/src/main/python/UpgradeHelper_HDP2.py 0c43850
ambari-server/src/main/resources/stacks/HDP/2.0.6/services/NAGIOS/package/scripts/params.py cb3d5c1
ambari-server/src/test/java/org/apache/ambari/server/upgrade/UpgradeCatalog160Test.java 59c73f2
Diff: https://reviews.apache.org/r/23174/diff/
Testing
-------
# verified hdfs-site.xml was updated with required properties and that Nagios started in my upgrade cluster
$ python UpgradeHelper_HDP2.py --hostname $HOSTNAME --user $USERNAME --password $PASSWORD --clustername $CLUSTERNAME update-configs
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 13:19.307s
[INFO] Finished at: Mon Jun 30 15:43:10 EDT 2014
[INFO] Final Memory: 21M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Jonathan Hurley