You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/08 05:31:57 UTC

[GitHub] [airflow] alexkruc commented on pull request #24895: Adding ElasticserachPythonHook - ES Hook With The Python Client

alexkruc commented on PR #24895:
URL: https://github.com/apache/airflow/pull/24895#issuecomment-1178570419

   @potiuk Is it possible to get your assistance on the failing tests?
   I have 2 failing tests:
   
   - The test [TestElasticsearchProviderProjectStructure](https://github.com/apache/airflow/blob/main/tests/always/test_project_structure.py#L473) is failing. From what I understand, it looks for all the available hooks, and looks that they have  a matching example in the examples folder [actual test](https://github.com/apache/airflow/blob/main/tests/always/test_project_structure.py#L182). 
   The thing is, that it's failing on the `ElasticsearchHook` which I deprecated (because I renamed it) in this PR. I don't want to add a test for a deprecated hook, because it's kinda beets the purpose.. Do you have any tips?
   
   - The `build docs` test is failing, on the new documentation that I've added - `hooks/elasticsearch.rst.rst:37:non-whitespace stripped by dedent`.  I compared the `dedent` clause with several other rst files, and it looked fine to me.. Also, the pre-commit hooks are passing on this file without any changes/failures..  Is there any possibility you can help me with this? 
   
   Sorry for the trouble :( I'm just kinda stuck and need an external opinion 🙏 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org