You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/08/11 21:20:33 UTC
[GitHub] [airflow] jedcunningham commented on a diff in pull request #25684: Add 'executor' label to airflow scheduler deployment
jedcunningham commented on code in PR #25684:
URL: https://github.com/apache/airflow/pull/25684#discussion_r943948597
##########
tests/charts/test_airflow_common.py:
##########
@@ -350,3 +350,24 @@ def test_priority_class_name(self):
priority = doc['spec']['template']['spec']['priorityClassName']
assert priority == f"low-priority-{component}"
+
+ @pytest.mark.parametrize(
+ "executor",
+ [
+ ("LocalExecutor"),
+ ("LocalKubernetesExecutor"),
+ ("CeleryExecutor"),
+ ("KubernetesExecutor"),
+ ("CeleryKubernetesExecutor"),
+ ],
+ )
+ def test_scheduler_deployment_has_executor_label(self, executor):
Review Comment:
Can you put this in `test_scheduler.py` instead?
##########
tests/charts/test_airflow_common.py:
##########
@@ -350,3 +350,24 @@ def test_priority_class_name(self):
priority = doc['spec']['template']['spec']['priorityClassName']
assert priority == f"low-priority-{component}"
+
+ @pytest.mark.parametrize(
+ "executor",
+ [
+ ("LocalExecutor"),
+ ("LocalKubernetesExecutor"),
+ ("CeleryExecutor"),
+ ("KubernetesExecutor"),
+ ("CeleryKubernetesExecutor"),
+ ],
+ )
+ def test_scheduler_deployment_has_executor_label(self, executor):
+ docs = render_chart(
+ values={"executor": executor},
+ show_only=[
+ "templates/scheduler/scheduler-deployment.yaml",
+ ],
Review Comment:
```suggestion
show_only=["templates/scheduler/scheduler-deployment.yaml"],
```
nit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org