You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@carbondata.apache.org by GitBox <gi...@apache.org> on 2021/10/12 07:08:09 UTC
[GitHub] [carbondata] jack86596 opened a new pull request #4234: [CARBONDATA-4304] Initialize CarbonEnv will try to create folder on local filesystem if storelocation is set without scheme
jack86596 opened a new pull request #4234:
URL: https://github.com/apache/carbondata/pull/4234
### Why is this PR needed?
If storelocation doesn't have scheme, file system is treated as local by default, not the file system defined by fs.defaultFS.
### What changes were proposed in this PR?
1. call fs.makeQualified and get the final storepath with correct scheme.
2. use storepath with scheme to create the folder, keep storepath without scheme in CarbonProperties, because storepath in CarbonProperties will be used to compare with spark.sql.warehouse.dir which doesn't have scheme also.
### Does this PR introduce any user interface change?
- No
### Is any new testcase added?
- Yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] jack86596 commented on pull request #4234: [CARBONDATA-4304] Initialize CarbonEnv will try to create folder on local filesystem if storelocation is set without scheme
Posted by GitBox <gi...@apache.org>.
jack86596 commented on pull request #4234:
URL: https://github.com/apache/carbondata/pull/4234#issuecomment-941115800
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4234: [CARBONDATA-4304] Initialize CarbonEnv will try to create folder on local filesystem if storelocation is set without scheme
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4234:
URL: https://github.com/apache/carbondata/pull/4234#issuecomment-941317805
Build Success with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/6051/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4234: [CARBONDATA-4304] Initialize CarbonEnv will try to create folder on local filesystem if storelocation is set without scheme
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4234:
URL: https://github.com/apache/carbondata/pull/4234#issuecomment-940979148
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4305/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] jack86596 commented on pull request #4234: [CARBONDATA-4304] Initialize CarbonEnv will try to create folder on local filesystem if storelocation is set without scheme
Posted by GitBox <gi...@apache.org>.
jack86596 commented on pull request #4234:
URL: https://github.com/apache/carbondata/pull/4234#issuecomment-948299774
> @jack86596 does this problem exists only with "carbon.storelocation" property?
yes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4234: [CARBONDATA-4304] Initialize CarbonEnv will try to create folder on local filesystem if storelocation is set without scheme
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4234:
URL: https://github.com/apache/carbondata/pull/4234#issuecomment-941317805
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4234: [CARBONDATA-4304] Initialize CarbonEnv will try to create folder on local filesystem if storelocation is set without scheme
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4234:
URL: https://github.com/apache/carbondata/pull/4234#issuecomment-940974002
Build Failed with Spark 2.3.4, Please check CI http://121.244.95.60:12602/job/ApacheCarbonPRBuilder2.3/6049/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4234: [CARBONDATA-4304] Initialize CarbonEnv will try to create folder on local filesystem if storelocation is set without scheme
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4234:
URL: https://github.com/apache/carbondata/pull/4234#issuecomment-941366217
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/441/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] jack86596 commented on pull request #4234: [CARBONDATA-4304] Initialize CarbonEnv will try to create folder on local filesystem if storelocation is set without scheme
Posted by GitBox <gi...@apache.org>.
jack86596 commented on pull request #4234:
URL: https://github.com/apache/carbondata/pull/4234#issuecomment-941115800
retest this please
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on pull request #4234: [CARBONDATA-4304] Initialize CarbonEnv will try to create folder on local filesystem if storelocation is set without scheme
Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #4234:
URL: https://github.com/apache/carbondata/pull/4234#issuecomment-948282373
@jack86596 does this problem exists only with "carbon.storelocation" property?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] kunal642 commented on pull request #4234: [CARBONDATA-4304] Initialize CarbonEnv will try to create folder on local filesystem if storelocation is set without scheme
Posted by GitBox <gi...@apache.org>.
kunal642 commented on pull request #4234:
URL: https://github.com/apache/carbondata/pull/4234#issuecomment-950099217
As carbon.storelocation is deprecated and would be removed soon, I don't think we should use it or fix issues related to it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4234: [CARBONDATA-4304] Initialize CarbonEnv will try to create folder on local filesystem if storelocation is set without scheme
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4234:
URL: https://github.com/apache/carbondata/pull/4234#issuecomment-940993230
Build Success with Spark 3.1, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_3.1/439/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [carbondata] CarbonDataQA2 commented on pull request #4234: [CARBONDATA-4304] Initialize CarbonEnv will try to create folder on local filesystem if storelocation is set without scheme
Posted by GitBox <gi...@apache.org>.
CarbonDataQA2 commented on pull request #4234:
URL: https://github.com/apache/carbondata/pull/4234#issuecomment-941336551
Build Success with Spark 2.4.5, Please check CI http://121.244.95.60:12602/job/ApacheCarbon_PR_Builder_2.4.5/4307/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@carbondata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org