You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pdfbox.apache.org by ti...@apache.org on 2021/06/17 06:07:05 UTC

svn commit: r1890853 - /pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/imageio/TIFFUtil.java

Author: tilman
Date: Thu Jun 17 06:07:04 2021
New Revision: 1890853

URL: http://svn.apache.org/viewvc?rev=1890853&view=rev
Log:
PDFBOX-4892: optimize, as suggested by valerybokov

Modified:
    pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/imageio/TIFFUtil.java

Modified: pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/imageio/TIFFUtil.java
URL: http://svn.apache.org/viewvc/pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/imageio/TIFFUtil.java?rev=1890853&r1=1890852&r2=1890853&view=diff
==============================================================================
--- pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/imageio/TIFFUtil.java (original)
+++ pdfbox/trunk/tools/src/main/java/org/apache/pdfbox/tools/imageio/TIFFUtil.java Thu Jun 17 06:07:04 2021
@@ -25,6 +25,7 @@ import javax.imageio.metadata.IIOMetadat
 import javax.imageio.metadata.IIOMetadataNode;
 import java.awt.image.BufferedImage;
 import static org.apache.pdfbox.tools.imageio.MetaUtil.debugLogMetadata;
+import org.w3c.dom.NodeList;
 
 /**
  * Used by ImageIOUtil to write TIFF files.
@@ -86,14 +87,15 @@ final class TIFFUtil
 
         IIOMetadataNode root = new IIOMetadataNode(metaDataFormat);
         IIOMetadataNode ifd;
-        if (root.getElementsByTagName("TIFFIFD").getLength() == 0)
+        NodeList nodeListTIFFIFD = root.getElementsByTagName("TIFFIFD");
+        if (nodeListTIFFIFD.getLength() == 0)
         {
             ifd = new IIOMetadataNode("TIFFIFD");
             root.appendChild(ifd);
         }
         else
         {
-            ifd = (IIOMetadataNode)root.getElementsByTagName("TIFFIFD").item(0);
+            ifd = (IIOMetadataNode) nodeListTIFFIFD.item(0);
         }
 
         // standard metadata does not work, so we set the DPI manually