[jira] [Commented] (AMQ-5621) Unit tests cleanup

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-5621?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15271164#comment-15271164 ] 

ASF subversion and git services commented on AMQ-5621:
------------------------------------------------------

Commit d1e2b768099febfacb9c401c05375b5413ca144a in activemq's branch refs/heads/master from [~tabish121]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=d1e2b76 ]

https://issues.apache.org/jira/browse/AMQ-5621

Update tests to not use hard coded broker port.

> Unit tests cleanup
> ------------------
>
>                 Key: AMQ-5621
>                 URL: https://issues.apache.org/jira/browse/AMQ-5621
>             Project: ActiveMQ
>          Issue Type: Improvement
>            Reporter: Timothy Bish
>            Assignee: Timothy Bish
>            Priority: Minor
>
> Many of the existing test cases take longer than they should and fail randomly due to BrokerService instances that are still running that have open JMX connectors etc.  We should take some time to review tests and clean up were we can.  
> Removing hard sleeps and using admin view to check statistics can dramatically shorten a test.  Also the tests can be configured not to create JMX connectors as none of them need that in the normal case.  
> Other tasks that could be done is to update tests to JUnit 4 based tests with test timeouts to help prevent CI hangs.  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)