You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/07/01 09:36:24 UTC

[GitHub] [spark] wangyum opened a new pull request #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13

wangyum opened a new pull request #25021: [SPARK-28221][BUILD] Upgrade janino to 3.0.13
URL: https://github.com/apache/spark/pull/25021
 
 
   ## What changes were proposed in this pull request?
   
   Mainly change logs:
   
   - Support for JDK 9/10 in Full Compiler
   - The syntax elements that can have modifiers now all have sets of "is...()" methods that check for each modifier. Some also have methods "getAccess()" and/or "getAnnotations()".
   - Implement "type annotations" (JLS8 9.7.4)
   - Implemented parsing (but not compilation) of "modular compilation units" (JLS11 7.3).
   - Replaced all "assert...Uncookable(..., Pattern messageRegex)" and "assert...Uncookable(..., String messageInfix)" method pairs with a single "assert...Uncookable(..., String messageRegex)" method.
   Minor refactoring: Allowed modifiers are now checked in the Parser, not in Java.*. This saves a lot of THROWS clauses.
   - Parse Type inference syntax: Type inference for generic instance creation implemented, test cases added.
   - Parse MethodReference, ClassInstanceCreationReference and ArrayCreationReference
   
   http://janino-compiler.github.io/janino/changelog.html
   
   ## How was this patch tested?
   
   Existing test
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org