You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2020/01/15 04:43:43 UTC
[GitHub] [druid] vogievetsky opened a new pull request #9190: Docs: move
search to the left
vogievetsky opened a new pull request #9190: Docs: move search to the left
URL: https://github.com/apache/druid/pull/9190
Put the doc search on the left of all the links
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] stale[bot] closed pull request #9190: Docs: move search to
the left
Posted by GitBox <gi...@apache.org>.
stale[bot] closed pull request #9190: Docs: move search to the left
URL: https://github.com/apache/druid/pull/9190
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] stale[bot] commented on issue #9190: Docs: move search to
the left
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #9190: Docs: move search to the left
URL: https://github.com/apache/druid/pull/9190#issuecomment-615914231
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] fjy commented on issue #9190: Docs: move search to the left
Posted by GitBox <gi...@apache.org>.
fjy commented on issue #9190: Docs: move search to the left
URL: https://github.com/apache/druid/pull/9190#issuecomment-576781655
@vogievetsky I think it is extremely hard to find the doc search bar and we should try to put it somewhere else. Can we have a sub-header bar or something?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] vogievetsky commented on issue #9190: Docs: move search to
the left
Posted by GitBox <gi...@apache.org>.
vogievetsky commented on issue #9190: Docs: move search to the left
URL: https://github.com/apache/druid/pull/9190#issuecomment-575421536
@fjy the [docusaurus](https://docusaurus.io/docs/en/search) template forces you to have a search in the header. Putting it in the ToC would be a lot more work. Do you think this position is better than before?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] fjy commented on issue #9190: Docs: move search to the left
Posted by GitBox <gi...@apache.org>.
fjy commented on issue #9190: Docs: move search to the left
URL: https://github.com/apache/druid/pull/9190#issuecomment-574494633
Vadim, can we move the search into the ToC and out of the nav bar?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] ccaominh commented on issue #9190: Docs: move search to the
left
Posted by GitBox <gi...@apache.org>.
ccaominh commented on issue #9190: Docs: move search to the left
URL: https://github.com/apache/druid/pull/9190#issuecomment-574777675
The security vulnerabilities travis job failure is unrelated to this PR. Please merge master to get the fix: https://github.com/apache/druid/pull/9189
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] stale[bot] commented on issue #9190: Docs: move search to
the left
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #9190: Docs: move search to the left
URL: https://github.com/apache/druid/pull/9190#issuecomment-602076019
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time or discuss it on the dev@druid.apache.org list. Thank you for your contributions.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org
[GitHub] [druid] fjy commented on issue #9190: Docs: move search to the left
Posted by GitBox <gi...@apache.org>.
fjy commented on issue #9190: Docs: move search to the left
URL: https://github.com/apache/druid/pull/9190#issuecomment-574494667
It feels so out of place and hard to find in the nav bar
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org