You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/09/21 16:29:36 UTC
[GitHub] [pinot] kkrugler opened a new issue #7457: PluginManager has fragile dependency on singleton and system properties
kkrugler opened a new issue #7457:
URL: https://github.com/apache/pinot/issues/7457
There's an issue with how the PluginManager (the only class using PluginClassLoader) gets initialized. It has a static PluginManager variable that uses system properties to locate classes to load, which is fragile as code that sets up this system property must run before the PluginManager class gets loaded. One example of this is `HadoopSegmentCreationMapper`.
In general having a singleton is problematic in an environment like Hadoop/Spark/Flink, where multiple task threads are running in the same JVM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] kkrugler commented on issue #7457: PluginManager has fragile dependency on singleton and system properties
Posted by GitBox <gi...@apache.org>.
kkrugler commented on issue #7457:
URL: https://github.com/apache/pinot/issues/7457#issuecomment-924153723
@richardstartin - wanted to mention this issue, for when you're looking into the PluginClassLoader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org