[GitHub] [calcite] FaxianZhao commented on a change in pull request #1188: [CALCITE-3034] CSV test case description does not match it's code logic

[GitBox <gi...@apache.org>]

FaxianZhao commented on a change in pull request #1188: [CALCITE-3034] CSV test case description does not match it's code logic
URL: https://github.com/apache/calcite/pull/1188#discussion_r281013187
 
 

 ##########
 File path: example/csv/src/test/java/org/apache/calcite/test/CsvTest.java
 ##########
 @@ -297,6 +297,16 @@ private static StringBuilder escapeString(StringBuilder buf, String s) {
         .returns("EMPNO=130; GENDER=F; NAME=Alice").ok();
   }
 
+  /** Filter that can be slightly handled by CsvFilterableTable. */
+  @Test public void testFilterableWhere3() throws SQLException {
+    final String sql = "select empno, gender, name from EMPS\n"
+            + " where gender = 'F' or empno > 125";
+    sql("filterable-model", sql)
 
 Review comment:
   > Why we update our code with `AND` while the test case sql is with `OR`, i kind of confused.
   
   Got it. Correct it with "where gender <> 'M' and empno > 125". 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services